Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deactivate only mode #41

Merged
merged 3 commits into from
Aug 30, 2024
Merged

feat: Add deactivate only mode #41

merged 3 commits into from
Aug 30, 2024

Conversation

mzaniolo
Copy link
Contributor

Closes #38

@mzaniolo mzaniolo requested a review from a team as a code owner August 22, 2024 07:20
@mzaniolo mzaniolo force-pushed the mzaniolo/deactivate-mode branch from 5dc3be2 to a7461f2 Compare August 22, 2024 07:45
Copy link

github-actions bot commented Aug 22, 2024

LCOV of commit 5acdabc during Rust workflow #294

Summary coverage rate:
  lines......: 81.2% (462 of 569 lines)
  functions..: 32.1% (123 of 383 functions)
  branches...: no data found

Files changed coverage rate:
                |Lines       |Functions  |Branches    
  Filename      |Rate     Num|Rate    Num|Rate     Num
  ====================================================
  src/config.rs |95.6%    136|34.7%   219|    -      0
  src/lib.rs    |96.6%     59|30.8%    26|    -      0
  src/zitadel.rs|77.4%    239|27.5%   102|    -      0

sirewix
sirewix previously approved these changes Aug 22, 2024
Copy link
Member

@emgrav emgrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question about the functionality and a tiny nit about a comment, but looks quite good otherwise.

src/lib.rs Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
emgrav
emgrav previously approved these changes Aug 22, 2024
Copy link
Member

@emgrav emgrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib.rs Outdated Show resolved Hide resolved
@mzaniolo mzaniolo force-pushed the mzaniolo/deactivate-mode branch from 762d16e to 7ba436e Compare August 29, 2024 17:51
@sirewix
Copy link
Contributor

sirewix commented Aug 30, 2024

Can you add some lines to the readme and/or config sample on how cache behaves when this mode is enabled. From what I see the cache is written as if all changes were processed, so it wouldn't be possible to run with disable_only and then without and get every change processed that wasn't processed during disable_only run.

@mzaniolo
Copy link
Contributor Author

Can you add some lines to the readme and/or config sample on how cache behaves when this mode is enabled. From what I see the cache is written as if all changes were processed, so it wouldn't be possible to run with disable_only and then without and get every change processed that wasn't processed during disable_only run.

Well, I think we should first be ask how we want the cache to behave when deactivate only is set. The issue doesn't say anything about it. Does anyone know how to answer that? Maybe @nikzen ?

Reissue of expired test certificates. The new expiration date is Aug 2034
@mzaniolo mzaniolo merged commit 5acdabc into main Aug 30, 2024
3 checks passed
@mzaniolo mzaniolo deleted the mzaniolo/deactivate-mode branch August 30, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivate only mode
4 participants