-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add deactivate only mode #41
Conversation
5dc3be2
to
a7461f2
Compare
LCOV of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question about the functionality and a tiny nit about a comment, but looks quite good otherwise.
a7461f2
to
762d16e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
762d16e
to
7ba436e
Compare
7ba436e
to
87b08d5
Compare
Can you add some lines to the readme and/or config sample on how cache behaves when this mode is enabled. From what I see the cache is written as if all changes were processed, so it wouldn't be possible to run with |
Well, I think we should first be ask how we want the cache to behave when deactivate only is set. The issue doesn't say anything about it. Does anyone know how to answer that? Maybe @nikzen ? |
Reissue of expired test certificates. The new expiration date is Aug 2034
Closes #38