Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Fix of the get pushers method usage with synapse #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nico-famedly
Copy link
Member

Hm, this field is listed as required in the specification and we just generate the models directly from the openapi spec. As such the proper fix for this would be to file a spec issue and in the meantime add a patch to our existing patch set to not mark this field as required and regenerate the spec.

Upstream requirement: https://github.com/matrix-org/matrix-spec/blob/99e2ff4927b56db927d52e82ff802b38f6fa8407/data/api/client-server/pusher.yaml#L103
Our patches: https://github.com/famedly/dart_openapi_codegen/tree/main/scripts

So while your change would work temporarily, it would break with the next spec update, if it isn't added as a patch.

@nico-famedly
Copy link
Member

I filed a spec issue for you, feel free to add context there, if you have any: matrix-org/matrix-spec#1643

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants