Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make various simple improvements to the developer UX #44

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Make various simple improvements to the developer UX #44

merged 9 commits into from
Feb 10, 2025
+125 −19

Conversation

tlater-famedly
Copy link
Contributor

No description provided.

@tlater-famedly tlater-famedly requested a review from a team as a code owner January 24, 2025 09:18
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (df7738c) to head (3d3e5eb).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files           1        1           
  Lines           9        9           
=======================================
  Hits            4        4           
  Misses          5        5

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7738c...3d3e5eb. Read the comment docs.

@tlater-famedly tlater-famedly force-pushed the tlater/devux branch 4 times, most recently from d3adb9c to 1c62cfa Compare January 24, 2025 09:35
@tlater-famedly tlater-famedly mentioned this pull request Jan 27, 2025
Draft
jannden
jannden previously approved these changes Jan 27, 2025
View reviewed changes
@tlater-famedly tlater-famedly mentioned this pull request Feb 4, 2025
Open
@tlater-famedly tlater-famedly force-pushed the tlater/devux branch 6 times, most recently from 2b4e1e9 to e57c896 Compare February 5, 2025 06:19
sirewix
sirewix reviewed Feb 6, 2025
View reviewed changes
.github/workflows/rust.yml Outdated Show resolved Hide resolved
sirewix
sirewix previously approved these changes Feb 6, 2025
View reviewed changes
@tlater-famedly tlater-famedly mentioned this pull request Feb 10, 2025
Open
@tlater-famedly tlater-famedly force-pushed the tlater/devux branch 3 times, most recently from c142145 to 517cda7 Compare February 10, 2025 05:18
emgrav
emgrav reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@emgrav emgrav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the tilde naming, could you document these changes a bit?

.github/actions/rust-prepare/prepare_rust.sh Show resolved Hide resolved
.github/workflows/rust-workflow.yml Outdated Show resolved Hide resolved
@tlater-famedly tlater-famedly merged commit 3d3e5eb into main Feb 10, 2025
9 checks passed
@tlater-famedly tlater-famedly deleted the tlater/devux branch February 10, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emgrav emgrav emgrav approved these changes

@sirewix sirewix sirewix left review comments

@jannden jannden jannden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlater-famedly @emgrav @sirewix @jannden