Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prebuilt drivers configs for ubuntu generic kernel 5.12.3-arch1-1 1 #466

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Add prebuilt drivers configs for ubuntu generic kernel 5.12.3-arch1-1 1 #466

merged 2 commits into from
Jul 21, 2021

Conversation

gauravgahlot
Copy link
Contributor

Signed-off-by: Gaurav Gahlot [email protected]

@poiana poiana requested review from leodido and maxgio92 July 16, 2021 09:38
@poiana
Copy link
Contributor

poiana commented Jul 16, 2021

Welcome @gauravgahlot! It looks like this is your first PR to falcosecurity/test-infra 🎉

@poiana
Copy link
Contributor

poiana commented Jul 16, 2021

Hi @gauravgahlot. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/M label Jul 16, 2021
@gauravgahlot
Copy link
Contributor Author

/assign

@leogr
Copy link
Member

leogr commented Jul 16, 2021

/ok-to-test

@leogr
Copy link
Member

leogr commented Jul 16, 2021

/retest build-drivers-ubuntu-generic-5-presubmit

@poiana
Copy link
Contributor

poiana commented Jul 16, 2021

@leogr: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test build-drivers-amazonlinux-presubmit
  • /test build-drivers-amazonlinux2-presubmit
  • /test build-images-autobump
  • /test build-images-build-drivers
  • /test build-images-golang
  • /test build-images-update-jobs
  • /test build-images-update-maintainers
  • /test build-images-build-libs
  • /test build-images-update-falco-k8s-manifests
  • /test build-drivers-centos-presubmit
  • /test check-prow-config
  • /test build-drivers-debian-presubmit
  • /test build-drivers-ubuntu-aws-3-presubmit
  • /test build-drivers-ubuntu-aws-4-presubmit
  • /test build-drivers-ubuntu-aws-5-presubmit
  • /test build-drivers-ubuntu-generic-3-presubmit
  • /test build-drivers-ubuntu-generic-4-presubmit
  • /test build-drivers-ubuntu-generic-5-presubmit

Use /test all to run the following jobs:

  • check-prow-config
  • build-drivers-ubuntu-generic-3-presubmit
  • build-drivers-ubuntu-generic-4-presubmit
  • build-drivers-ubuntu-generic-5-presubmit

In response to this:

/retest build-drivers-ubuntu-generic-5-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Jul 16, 2021

@leogr: The /retest command does not accept any targets.

@poiana , sorry 🙏

/test build-drivers-ubuntu-generic-5-presubmit

😸

@leogr
Copy link
Member

leogr commented Jul 19, 2021

/test build-drivers-ubuntu-generic-5-presubmit

@gauravgahlot
Copy link
Contributor Author

@leogr Is there anything I can do to fix the tests?

@maxgio92
Copy link
Member

Hey @gauravgahlot, we're checking

maxgio92
maxgio92 requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@maxgio92 maxgio92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gauravgahlot, thank you. I left some suggestions, as the kernelrelease in the Driverkit config should contain the kernel release only, without the version (as for the output of uname -r) :)

PS: you can read more here about Driverkit configuration.

driverkit/config/17f5df52a7d9ed6bb12d3b1768460def8439936d/ubuntu-generic_5.12.3-arch1-1_1.yaml Outdated
@@ -0,0 +1,6 @@
kernelversion: 1
kernelrelease: 5.12.3-arch1-1_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kernelrelease: 5.12.3-arch1-1_1
kernelrelease: 5.12.3-arch1-1

driverkit/config/2aa88dcf6243982697811df4c1b484bcbe9488a2/ubuntu-generic_5.12.3-arch1-1_1.yaml Outdated
@@ -0,0 +1,6 @@
kernelversion: 1
kernelrelease: 5.12.3-arch1-1_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kernelrelease: 5.12.3-arch1-1_1
kernelrelease: 5.12.3-arch1-1

driverkit/config/5c0b863ddade7a45568c0ac97d037422c9efb750/ubuntu-generic_5.12.3-arch1-1_1.yaml Outdated
@@ -0,0 +1,6 @@
kernelversion: 1
kernelrelease: 5.12.3-arch1-1_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kernelrelease: 5.12.3-arch1-1_1
kernelrelease: 5.12.3-arch1-1

driverkit/config/85c88952b018fdbce2464222c3303229f5bfcfad/ubuntu-generic_5.12.3-arch1-1_1.yaml Outdated
@@ -0,0 +1,6 @@
kernelversion: 1
kernelrelease: 5.12.3-arch1-1_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kernelrelease: 5.12.3-arch1-1_1
kernelrelease: 5.12.3-arch1-1

driverkit/config/ae104eb20ff0198a5dcb0c91cc36c86e7c3f25c7/ubuntu-generic_5.12.3-arch1-1_1.yaml Outdated
@@ -0,0 +1,6 @@
kernelversion: 1
kernelrelease: 5.12.3-arch1-1_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kernelrelease: 5.12.3-arch1-1_1
kernelrelease: 5.12.3-arch1-1

@gauravgahlot
fix kernelrelease
9ac1369 
Signed-off-by: Gaurav Gahlot <[email protected]>
@gauravgahlot
Copy link
Contributor Author

Thank you @maxgio92. I have made the suggested changes. 🚀

maxgio92
maxgio92 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you @gauravgahlot! :)

@poiana poiana added the lgtm label Jul 21, 2021
@poiana
Copy link
Contributor

poiana commented Jul 21, 2021

LGTM label has been added.

Git tree hash: 4b240f2db611c6958194ba19472c7f796839ba80

@poiana
Copy link
Contributor

poiana commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravgahlot, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fc1c00c into falcosecurity:master Jul 21, 2021
@gauravgahlot gauravgahlot deleted the support-ubuntu-generic_5.12.3-arch1-1_1 branch July 21, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgio92 maxgio92 maxgio92 approved these changes

@leodido leodido Awaiting requested review from leodido

Assignees

@maxgio92 maxgio92

@gauravgahlot gauravgahlot

Labels
approved dco-signoff: yes lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauravgahlot @poiana @leogr @maxgio92