Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: prebuild module for bottlerocketos_5.4.50_1 #179

Conversation

faarshad
Copy link
Contributor

Signed-off-by: Fahad Arshad [email protected]

This is for bottlerocketos with the AMI name bottlerocket-aws-k8s-1.16-x86_64-v1.0.1-2a181156.

@poiana
Copy link
Contributor

poiana commented Sep 17, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

Unfortunately driverkit does not support bottlerocket yet.

There've been some requests to support it in the past and some discussions around it (see here).

We do not have cycles to work on a bottlerocket driverkit builder right now and we'd love to review a PR in driverkit that adds one!

@leodido
Copy link
Member

leodido commented Sep 18, 2020

/hold

@faarshad
Copy link
Contributor Author

Hi @leodido ,
I tested building bottlerocket falco driver using the vanilla builder with kernelconfigdata embedded into the yaml and it seems to work fine. The kernel & kernel-devel packages for bottlerocket don't seem to be available publicly and neither is /proc/config.gz, so I am wondering whether it will be acceptable to put in a PR in https://github.com/falcosecurity/test-infra with kernelconfigdata for bottlerocket-5.4.50 in it using the vanilla builder. We can name the output .ko file something bottlerocket specific like falco_bottlerocket_5.4.50_1.ko

We will have to add a section a called drivers/build/vanilla in circleci jobs
WDYT?

@faarshad
Copy link
Contributor Author

tagging falco maintainers to solicit some feedback ⬆️ cc: @leodido @leogr @fntlnz @kris-nova

@leodido
Copy link
Member

leodido commented Sep 29, 2020

Hey @farshad-hobsons thanks for investigating this topic.

Anyways, I'd personally avoid putting vanilla drivers in the drivers build grid in this repository.

Furthermore, I'm not still sure that using the vanilla builder + config.gz is the correct way to go for bottlerocket OS.

Please look here:

These seem to be the steps a custom bottlerocket builder for driverkit must do, IMHO.

Waiting for the feedback of other test-infra maintainers @falcosecurity/test-infra-maintainers

@faarshad
Copy link
Contributor Author

Thank you for your feedback. Closing this in favor of falcosecurity/driverkit#75

@faarshad faarshad closed this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants