fix(driver): check rename family syscalls are defined#401
Merged
poiana merged 1 commit intofalcosecurity:masterfrom Jun 17, 2022
Merged
fix(driver): check rename family syscalls are defined#401poiana merged 1 commit intofalcosecurity:masterfrom
rename family syscalls are defined#401poiana merged 1 commit intofalcosecurity:masterfrom
Conversation
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it> Co-authored-by: Dima Kogan <dima@secretsauce.net>
poiana
added
release-note-none
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 020891afdbb9396a534c7bd7fc2b95c7b8686e24 |
Contributor
|
Honestly, the more i see these kind of issues, the more i think my approach in #86 is a winning one... |
leogr
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
What this PR does / why we need it:
This PR defines entries in our tables only when the syscall number is defined in that architecture. More precisely, this pull request fixes the bug on
riscv64highlighted by @dkogan here 👉 #399The changes proposed are just an extension of the patch suggested by @dkogan.
Please note: I would love to have the conditional compilation around every single syscall in our tables, right now I just addressed the
renamefamily.Which issue(s) this PR fixes:
Fixes #399
Special notes for your reviewer:
Does this PR introduce a user-facing change?: