new(ci): add a zig build job plus a composite action to setup zig.#2078
new(ci): add a zig build job plus a composite action to setup zig.#2078
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e4a7231 to
33e0670
Compare
| shell: bash | ||
| id: zig | ||
| env: | ||
| ZIG_VERSION: '0.14.0-dev.1588+2111f4c38' |
There was a problem hiding this comment.
We need to use a development version of zig since it needs my patch: ziglang/zig#21253
Hopefully they'll release 0.14.0 soon.
Also, keeping this PR wip as master zig artifacts are not kept around, ie: once a new master artifact is released, the old ones get removed.
There was a problem hiding this comment.
As a workaround, i am using actions/cache to cache the zig toolchain.
33e0670 to
e34fbad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
- Coverage 73.58% 73.58% -0.01%
==========================================
Files 253 253
Lines 31867 31867
Branches 5640 5641 +1
==========================================
- Hits 23449 23448 -1
+ Misses 8414 8410 -4
- Partials 4 9 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
653a9e0 to
0b6cc6a
Compare
|
/milestone 0.19.0 |
Moreover, use zig version as cache key too. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
ce47b67 to
3c47fcf
Compare
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
3c47fcf to
dd841b9
Compare
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
| # Add here the name for new scap-files | ||
| set(SCAP_FILE_NAMES "kexec_arm64.scap" "kexec_x86.scap" "sample.scap") | ||
| set(SCAP_FILE_DOWNLOAD_PREFIX "https://download.falco.org/fixtures/libs/scap_files") | ||
| set(SCAP_FILE_DOWNLOAD_PREFIX |
There was a problem hiding this comment.
To workaround some scarf-related issues, just skip using it while downloading text fixtures.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR adds a composite action to setup zig (stolen by my Falco PR: falcosecurity/falco#3307, that will be of course updated to use the libs provided action once this gets merged), and adds a CI job to test build of sinsp-example with zig.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: