Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userspace/libsinsp): podman support during scap files replay #1851

Merged
merged 3 commits into from
May 8, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 8, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area libsinsp

What this PR does / why we need it:

This PR fixes podman support while replaying scap files; moreover, it fixes a small bug in container.type filtercheck.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(userspace/libsinsp): podman support during scap files replay

@FedeDP
Copy link
Contributor Author

FedeDP commented May 8, 2024

cc @deepskyblue86 @irozzo-1A

@FedeDP
Copy link
Contributor Author

FedeDP commented May 8, 2024

/milestone 0.17.0

@poiana poiana added the size/S label May 8, 2024
@poiana poiana added this to the 0.17.0 milestone May 8, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented May 8, 2024

/cc @Andreagit97 @leogr

@poiana poiana requested review from Andreagit97 and leogr May 8, 2024 07:53
leogr
leogr previously approved these changes May 8, 2024
@poiana poiana added the lgtm label May 8, 2024
Copy link
Contributor

@deepskyblue86 deepskyblue86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

userspace/libsinsp/container_engine/docker/podman.cpp Outdated Show resolved Hide resolved
…ing_info`.

Signed-off-by: Federico Di Pierro <[email protected]>

Co-authored-by: Angelo Puglisi <[email protected]>
@FedeDP FedeDP force-pushed the fix/podman_api_sock_capture branch from ef446da to ce04c9f Compare May 8, 2024 09:36
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 97f582f into master May 8, 2024
39 of 40 checks passed
@poiana poiana deleted the fix/podman_api_sock_capture branch May 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants