Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(userspace/libsinsp): minor changes in state API, expose new threadinfo fields #1838

Merged
merged 1 commit into from
May 6, 2024

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind feature

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it:

This is the first PR related to solving #1712, contributing the following:

  • Optimize memory allocations for static fields
  • Ground work for supporting subtable access and complex state types
  • Inlining functions wherever possible
  • Improve checks in static and dynamic state fields definitions
  • Expose new fields in thread infos

Which issue(s) this PR fixes:

Special notes for your reviewer:

/milestone 0.17.0

Does this PR introduce a user-facing change?:

refactor(userspace/libsinsp): minor changes in state API, expose new threadinfo fields

…threadinfo fields

* Optimize memory allocations for static fields
* Ground work for supporting subtable access and complex state types
* Inlining functions wherever possible
* Improve checks in static and dynamic state fields defintions
* Expose new fields in thread infos

Co-authored-by: Gianmatteo Palmieri <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 6, 2024

LGTM label has been added.

Git tree hash: 8d3fe3961c77bc64f68a70bf52160ae9c275c113

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 24696e0 into master May 6, 2024
39 of 40 checks passed
@poiana poiana deleted the refactor/update-state-api-sinsp branch May 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants