refactor: Use string_view in event filters and more #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federico-sysdig
force-pushed
the
refactor-use-string-view-in-filters
branch
from
8ceee69
to
f9393dd
Compare
|
Since we are a bit late for the 0.16.0 tag, i propose: |
federico-sysdig
force-pushed
the
refactor-use-string-view-in-filters
branch
from
f9393dd
to
b9d6972
Compare
|
/assign @FedeDP |
federico-sysdig
force-pushed
the
refactor-use-string-view-in-filters
branch
from
b9d6972
to
006e6f6
Compare
FedeDP
reviewed
May 3, 2024
userspace/libsinsp/base64.h
Outdated
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cstdint> | |||
There was a problem hiding this comment.
This change was already merged and can be removed :) (#1799)
There was a problem hiding this comment.
I've rebased everything.
Signed-off-by: Federico Aponte <[email protected]>
Signed-off-by: Federico Aponte <[email protected]>
federico-sysdig
force-pushed
the
refactor-use-string-view-in-filters
branch
from
006e6f6
to
8d0c4b5
Compare
|
LGTM label has been added. Git tree hash: 225128f4dc00cf1a63bb56b4536a9d3039f02a77
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, federico-sysdig, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Some refactorings to try and improve the performance of event filtering. In particular the PR concentrates on avoiding string creation by passing around only
std::string_viewobjects.Some minor improvements have been also applied, such as creating objects controlled by a
shared_ptrwithstd::make_sharedto ensure that the control block is not allocated separate from the object, thus avoiding one allocation and making it more cache friendly.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: