fix(ci): properly install rpm systemd-rpm-macro package on building packages pipeline#3521
Merged
fix(ci): properly install rpm systemd-rpm-macro package on building packages pipeline#3521
systemd-rpm-macro package on building packages pipeline#3521Conversation
… packages pipeline. Refs #3503: we need it because rpm pre/post install/remove scripts are evaluated at rpm package building time. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/milestone 0.41.0 |
FedeDP
commented
Mar 31, 2025
| - name: Install build deps | ||
| run: | | ||
| sudo apt update && sudo apt install -y --no-install-recommends ca-certificates cmake curl wget build-essential git pkg-config autoconf automake libtool m4 rpm | ||
| sudo apt update && sudo apt install -y --no-install-recommends ca-certificates cmake curl wget build-essential git pkg-config autoconf automake libtool m4 rpm alien |
Contributor
Author
There was a problem hiding this comment.
We use alien to download the rpm package and convert it to deb one and install it.
leogr
approved these changes
Apr 1, 2025
LucaGuerra
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
We need it because rpm pre/post install/remove scripts are evaluated at rpm package building time.
Bug introduced when porting the CI to zig: #3307
Which issue(s) this PR fixes:
Fixes #3503
Special notes for your reviewer:
Does this PR introduce a user-facing change?: