chore(falco.yaml): use HOME env var for ebpf probe path.#2971
Merged
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Contributor
Author
|
/milestone 0.37.0 |
Contributor
Author
|
Wow Melissa, quicker than me 😆 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Since #2918 is now merged, we can freely use env var.
This is more correct since eg:
falcoctlwill copy built drivers there: https://github.com/falcosecurity/falcoctl/blob/main/pkg/driver/type/bpf.go#L55.Most of the time, both falcoctl and Falco will run as root, thus the env var will resolve to the current
/root/.falco/falco-bpf.o.But if user decides to eg: have a Falco user with reduced privileges, she/he will still be able to let falcoctl install its ebpf probe and then Falco would start without issues.
Example output without and with
sudo:Also, this was already the default behavior when
FALCO_BPF_PROBE=""env var was passed:falco/userspace/falco/app/actions/helpers_inspector.cpp
Line 114 in cbbcb61
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: