fix(ci): simplify and fix multi-arch image publishing process#2542
Merged
poiana merged 1 commit intofalcosecurity:masterfrom May 12, 2023
Merged
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
Contributor
|
/milestone 0.35.0 |
Contributor
|
LGTM label has been added. DetailsGit tree hash: ade5420f7b4d07d0e8bdd63c1f4dd8b1d28c2b56 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Refs #2501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/area CI
What this PR does / why we need it:
This is a refactor and fix of the container image publishing process. There are two major changes:
:x86_64-0.35.0). This is done because in order to create a multiarch (index,manifest.list) manifest easily we need manifests with the referenced digests already published. It is probably possible to do it without (buildx can do something similar) but it may involve a local registry or some more complicated process. I think this is fine for now.docker.io/falcosecurity/falco) and then adds any additional tags or registries (ECR, latest tags...). This simplifies things especially when the next PR will be published, which is related to signatures with cosign.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Note that the arch specific tags are not pushed to ECR. We can change this behavior
Does this PR introduce a user-facing change?: