Skip to content

fix: ci Falco version#2516

Merged
poiana merged 4 commits intomasterfrom
fix/ci_falco_version
Apr 28, 2023
Merged

fix: ci Falco version#2516
poiana merged 4 commits intomasterfrom
fix/ci_falco_version

Conversation

@FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Apr 28, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Try to fix CI Falco version for newly introduced reusable build packages.
Moreover, drop installation of git from x86_64 only repository for centos7.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Refs #2501

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…kages workflow.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the fix/ci_falco_version branch from f8aa4d3 to d9fa870 Compare April 28, 2023 07:24
…e it in subsequent steps, in reusable build packages.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the fix/ci_falco_version branch from d9fa870 to 0e6e6c3 Compare April 28, 2023 07:25
@FedeDP FedeDP changed the title wip: fix: ci Falco version fix: ci Falco version Apr 28, 2023
leogr
leogr previously approved these changes Apr 28, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe for another PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by mistake :/

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Luca Guerra <luca@guerra.sh>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 28, 2023

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 28, 2023

/unhold

@poiana
Copy link
Contributor

poiana commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a193a46 into master Apr 28, 2023
@poiana poiana deleted the fix/ci_falco_version branch April 28, 2023 08:14
@LucaGuerra LucaGuerra added this to the 0.35.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants