chore(ci): properly install recent version of git (needed >= 2.18 by checkout action)#2514
Merged
chore(ci): properly install recent version of git (needed >= 2.18 by checkout action)#2514
Conversation
…checkout action) to fix Falco versioning. Moreover, fixed path to output packages from Falco `make package` target. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Contributor
Author
Contributor
Author
|
/milestone 0.35.0 |
Contributor
Author
|
/hold |
FedeDP
commented
Apr 27, 2023
| source /opt/rh/devtoolset-9/enable | ||
| yum install -y git wget make m4 rpm-build | ||
| yum install -y wget make m4 rpm-build | ||
| yum -y install https://packages.endpointdev.com/rhel/7/os/x86_64/endpoint-repo.x86_64.rpm |
Contributor
Author
There was a problem hiding this comment.
Repo that provides recent git version.
A recent git version is needed by checkout action.
FedeDP
commented
Apr 27, 2023
| name: falco-${{ steps.store_version.outputs.version }}-${{ inputs.arch }}.tar.gz | ||
| path: | | ||
| ${{ github.workspace }}/build/packages/falco-*.tar.gz | ||
| ${{ github.workspace }}/build/falco-*.tar.gz |
Contributor
Author
|
Further fixes on top of #2501 . |
jasondellaluce
approved these changes
Apr 27, 2023
leogr
approved these changes
Apr 27, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/unhold Lets try! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
Moreover, fixed path to output packages from Falco
make packagetarget.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: