Skip to content

fix(ci): remove unnecessary mv#2512

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
LucaGuerra:fix/ci-unnecessary-mv
Apr 27, 2023
Merged

fix(ci): remove unnecessary mv#2512
poiana merged 1 commit intofalcosecurity:masterfrom
LucaGuerra:fix/ci-unnecessary-mv

Conversation

@LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

What this PR does / why we need it:

The file name downloaded from the artifact is already bpf_probe.skel.h

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 27, 2023

LGTM label has been added.

DetailsGit tree hash: f4fc6fe4c66ee569a7a7a3a7860cbcd2bdf19813

@FedeDP
Copy link
Contributor

FedeDP commented Apr 27, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Apr 27, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fe8899c into falcosecurity:master Apr 27, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Apr 27, 2023

Further fixes on top of #2501 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants