Skip to content

new(ci): gha master and release workflows #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poiana merged 22 commits into from
Apr 27, 2023
Merged

new(ci): gha master and release workflows #2501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9790887
new(ci): added github action workflows for dev and release CI (packag…
FedeDP Apr 17, 2023
3b7b5a5
chore(ci): add proper concurrency groups for master and release CI.
FedeDP Apr 17, 2023
f9333ef
chore(ci): disable on push: master trigger for ci.yml.
FedeDP Apr 18, 2023
ca345ff
chore(ci): commented out circleCI master and release jobs.
FedeDP Apr 18, 2023
75759c8
update(ci): add an arm test CI job.
FedeDP Apr 18, 2023
0c737ac
chore(ci): fixed up master and release yamls.
FedeDP Apr 18, 2023
bb588f9
cleanup(ci): dropped test arm64 job from pull_request CI, since it is…
FedeDP Apr 18, 2023
d87cb9d
chore(ci): multiple fixes to new master and release ci jobs.
FedeDP Apr 18, 2023
f070669
fix(ci): fixed reusable_build_packages to properly install `git` befo…
FedeDP Apr 18, 2023
94b7d84
chore(ci): added aws credentials role to the reusable_publish_package…
FedeDP Apr 19, 2023
cae49ae
chore(ci): run reusable_build_docker workflow without any container.
FedeDP Apr 19, 2023
dc37254
chore(ci): test reusable_build_docker from PR CI.
FedeDP Apr 19, 2023
727e5a9
fix(ci): do not use `inputs.tagname`. Instead, rely on `github.ref_na…
FedeDP Apr 19, 2023
d401d44
chore(ci): install awscli in reusable_build_docker workflow.
FedeDP Apr 19, 2023
a66fa66
cleanup(ci): dropped test jobs in CI.yml.
FedeDP Apr 19, 2023
62d80bc
chore(ci): avoid publishing images in `reusable_build_docker.yaml` wo…
FedeDP Apr 19, 2023
84db6fb
chore(ci): `reusable_public_packages` needs proper permissions.
FedeDP Apr 20, 2023
8fa85f9
chore(ci): added AWS ECR login to reusable_publish_docker.
FedeDP Apr 27, 2023
9093d82
chore(ci): renamed `bucket` to `bucket_suffix`.
FedeDP Apr 27, 2023
c4faed9
chore(ci): added some comments.
FedeDP Apr 27, 2023
9ce05be
chore(ci): use Noelware/docker-manifest-action pinned version to late…
FedeDP Apr 27, 2023
337b9e6
chore(ci): improved GPG_KEY management through an env.
FedeDP Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
284 changes: 142 additions & 142 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,78 +755,78 @@ workflows:
- "tests-driver-loader-integration":
requires:
- "build-centos7"
- "rpm-sign":
context: falco
filters:
tags:
ignore: /.*/
branches:
only: master
requires:
- "tests-integration"
- "tests-integration-arm64"
- "publish-packages-dev":
context:
- falco
- test-infra
filters:
tags:
ignore: /.*/
branches:
only: master
requires:
- "rpm-sign"
- "tests-integration-static"
- "publish-packages-deb-dev":
context:
- falco
- test-infra
filters:
tags:
ignore: /.*/
branches:
only: master
requires:
- "tests-integration"
- "tests-integration-arm64"
- "build-docker-dev":
context:
- falco
- test-infra
filters:
tags:
ignore: /.*/
branches:
only: master
requires:
- "publish-packages-dev"
- "publish-packages-deb-dev"
- "tests-driver-loader-integration"
- "build-docker-dev-arm64":
context:
- falco
- test-infra
filters:
tags:
ignore: /.*/
branches:
only: master
requires:
- "publish-packages-dev"
- "publish-packages-deb-dev"
- "tests-driver-loader-integration"
- "publish-docker-dev":
context:
- falco
- test-infra
filters:
tags:
ignore: /.*/
branches:
only: master
requires:
- "build-docker-dev"
- "build-docker-dev-arm64"
# - "rpm-sign":
Copy link
Contributor Author

@FedeDP FedeDP Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid conflicts; disable circleCI jobs.

# context: falco
# filters:
# tags:
# ignore: /.*/
# branches:
# only: master
# requires:
# - "tests-integration"
# - "tests-integration-arm64"
# - "publish-packages-dev":
# context:
# - falco
# - test-infra
# filters:
# tags:
# ignore: /.*/
# branches:
# only: master
# requires:
# - "rpm-sign"
# - "tests-integration-static"
# - "publish-packages-deb-dev":
# context:
# - falco
# - test-infra
# filters:
# tags:
# ignore: /.*/
# branches:
# only: master
# requires:
# - "tests-integration"
# - "tests-integration-arm64"
# - "build-docker-dev":
# context:
# - falco
# - test-infra
# filters:
# tags:
# ignore: /.*/
# branches:
# only: master
# requires:
# - "publish-packages-dev"
# - "publish-packages-deb-dev"
# - "tests-driver-loader-integration"
# - "build-docker-dev-arm64":
# context:
# - falco
# - test-infra
# filters:
# tags:
# ignore: /.*/
# branches:
# only: master
# requires:
# - "publish-packages-dev"
# - "publish-packages-deb-dev"
# - "tests-driver-loader-integration"
# - "publish-docker-dev":
# context:
# - falco
# - test-infra
# filters:
# tags:
# ignore: /.*/
# branches:
# only: master
# requires:
# - "build-docker-dev"
# - "build-docker-dev-arm64"
# - "quality/static-analysis" # This is temporarily disabled: https://github.com/falcosecurity/falco/issues/1526
release:
jobs:
Expand All @@ -848,73 +848,73 @@ workflows:
only: /.*/
branches:
ignore: /.*/
- "rpm-sign":
context: falco
requires:
- "build-centos7"
- "build-arm64"
filters:
tags:
only: /.*/
branches:
ignore: /.*/
- "publish-packages":
context:
- falco
- test-infra
requires:
- "build-musl"
- "rpm-sign"
filters:
tags:
only: /.*/
branches:
ignore: /.*/
- "publish-packages-deb":
context:
- falco
- test-infra
requires:
- "build-centos7"
- "build-arm64"
filters:
tags:
only: /.*/
branches:
ignore: /.*/
- "build-docker":
context:
- falco
- test-infra
requires:
- "publish-packages"
- "publish-packages-deb"
filters:
tags:
only: /.*/
branches:
ignore: /.*/
- "build-docker-arm64":
context:
- falco
- test-infra
requires:
- "publish-packages"
- "publish-packages-deb"
filters:
tags:
only: /.*/
branches:
ignore: /.*/
- "publish-docker":
context:
- falco
- test-infra
requires:
- "build-docker"
- "build-docker-arm64"
filters:
tags:
only: /.*/
branches:
ignore: /.*/
# - "rpm-sign":
# context: falco
# requires:
# - "build-centos7"
# - "build-arm64"
# filters:
# tags:
# only: /.*/
# branches:
# ignore: /.*/
# - "publish-packages":
# context:
# - falco
# - test-infra
# requires:
# - "build-musl"
# - "rpm-sign"
# filters:
# tags:
# only: /.*/
# branches:
# ignore: /.*/
# - "publish-packages-deb":
# context:
# - falco
# - test-infra
# requires:
# - "build-centos7"
# - "build-arm64"
# filters:
# tags:
# only: /.*/
# branches:
# ignore: /.*/
# - "build-docker":
# context:
# - falco
# - test-infra
# requires:
# - "publish-packages"
# - "publish-packages-deb"
# filters:
# tags:
# only: /.*/
# branches:
# ignore: /.*/
# - "build-docker-arm64":
# context:
# - falco
# - test-infra
# requires:
# - "publish-packages"
# - "publish-packages-deb"
# filters:
# tags:
# only: /.*/
# branches:
# ignore: /.*/
# - "publish-docker":
# context:
# - falco
# - test-infra
# requires:
# - "build-docker"
# - "build-docker-arm64"
# filters:
# tags:
# only: /.*/
# branches:
# ignore: /.*/
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@ name: CI Build
on:
pull_request:
branches: [master]
push:
Copy link
Contributor Author

@FedeDP FedeDP Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have a dedicated master.yaml for that.

branches: [master]
workflow_dispatch:

# Checks if any concurrent jobs under the same pull request or branch are being executed
# NOTE: this will cancel every workflow that is being ran as group is just the github ref (without the workflow name)
# NOTE: this will cancel every workflow that is being ran against a PR as group is just the github ref (without the workflow name)
concurrency:
group: ${{ github.head_ref || github.run_id }}
cancel-in-progress: true
Expand Down
54 changes: 54 additions & 0 deletions .github/workflows/master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: Dev Packages and Docker images
on:
push:
branches: [master]

# Checks if any concurrent jobs is running for master CI and eventually cancel it
concurrency:
Copy link
Contributor Author

@FedeDP FedeDP Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1876

group: ci-master
cancel-in-progress: true

jobs:
build-dev-packages:
uses: falcosecurity/falco/.github/workflows/reusable_build_packages.yaml@master
with:
arch: x86_64
secrets: inherit

build-dev-packages-arm64:
uses: falcosecurity/falco/.github/workflows/reusable_build_packages.yaml@master
with:
arch: aarch64
secrets: inherit

publish-dev-packages:
needs: [build-dev-packages, build-dev-packages-arm64]
uses: falcosecurity/falco/.github/workflows/reusable_publish_packages.yaml@master
with:
bucket: '-dev'
version: ${{ needs.build-dev-packages.outputs.version }}
secrets: inherit

# Both build-dev-docker and its arm64 counterpart require build-dev-packages because they use its output
build-dev-docker:
Copy link
Contributor Author

@FedeDP FedeDP Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both build-dev-docker and its arm64 counterpart require build-dev-packages because they use its output.

Copy link
Contributor Author

@FedeDP FedeDP Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for the release CI.

needs: [build-dev-packages, publish-dev-packages]
uses: falcosecurity/falco/.github/workflows/reusable_build_docker.yaml@master
with:
arch: x86_64
bucket: '-dev'
version: ${{ needs.build-dev-packages.outputs.version }}
secrets: inherit

build-dev-docker-arm64:
needs: [build-dev-packages, publish-dev-packages]
uses: falcosecurity/falco/.github/workflows/reusable_build_docker.yaml@master
with:
arch: aarch64
bucket: '-dev'
version: ${{ needs.build-dev-packages.outputs.version }}
secrets: inherit

publish-dev-docker:
needs: [build-dev-docker, build-dev-docker-arm64]
uses: falcosecurity/falco/.github/workflows/reusable_publish_docker.yaml@master
secrets: inherit
Loading