fix: falco-driver-loader source-only print env vars by steakunderscore · Pull Request #2353 · falcosecurity/falco

steakunderscore · 2023-01-12T17:18:12Z

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2352

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(falco-driver-loader): --source-only now prints the values as env vars

poiana · 2023-01-12T17:18:21Z

Welcome @steakunderscore! It looks like this is your first PR to falcosecurity/falco 🎉

ggilligan12 · 2023-01-12T17:33:51Z

endorse

jasondellaluce · 2023-01-12T17:59:08Z

/milestone 0.34.0

FedeDP · 2023-01-13T08:32:23Z

Hi! Thanks for this PR!

echo " --source-only skip execution and allow sourcing in another script"

This is from the help message of falco-driver-loader. I assume we don't want to print anything in that case; but i fully agree with your idea; we might add a new subcmd, like --print-env ?

steakunderscore · 2023-01-13T11:18:35Z

hmm.. I think this diff actually stems from my lack of understanding of bash sourcing my comment on #2352.

I'd be happy to convert this to a --print-env env flag if you guys think this would be useful? If not, feel free to close this without merging.

FedeDP · 2023-01-13T11:21:51Z

I think it is pretty useful to add the --print-env :)
I'd also print TARGET_ID like https://github.com/falcosecurity/falco/blob/master/scripts/falco-driver-loader#L314 does!

leogr · 2023-01-13T11:30:34Z

I like it. I see some failing tests, any clue? 🤔

steakunderscore · 2023-01-13T12:03:18Z

I'll get this cleaned up. I'll also take a look at the tests.

FedeDP · 2023-01-16T15:31:34Z

I don't think tests are actually your fault; we are having some weird errors lately :/

leogr · 2023-01-23T10:55:39Z

hmm.. I think this diff actually stems from my lack of understanding of bash sourcing my comment on #2352.

I'd be happy to convert this to a --print-env env flag if you guys think this would be useful? If not, feel free to close this without merging.

Hey @steakunderscore

My vote goes for --print-env!

PS
We are close to the Falco release (by the end of this month). If you can't update the PR in time, I will move it to the next milestone.

leogr · 2023-01-26T11:35:41Z

/milestone 0.35.0

leogr · 2023-06-22T07:21:06Z

I did not notice that --print-env change request was already addressed, so this should be ready for review.

cc @FedeDP @Andreagit97 @therealbobo

leogr · 2023-06-22T07:21:33Z

/remove-lifecycle rotten

therealbobo · 2023-06-22T08:27:04Z

Left a comment but for the rest LGTM! 😄

FedeDP · 2023-06-22T08:31:49Z

LGTM too; i'd wait for Falco patch release 0.35.1 to be out, before going on with this; great refactor though, much more readable script!

FedeDP

/approve

poiana · 2023-08-31T07:11:40Z

LGTM label has been added.

Details

Git tree hash: 7981fe2566489ad317956375788434454a2a2d91

Andreagit97

/approve
Thank you andò sorry for the delay!

Andreagit97 · 2023-08-31T09:16:32Z

/reopen

poiana · 2023-08-31T09:16:36Z

@Andreagit97: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fixes falcosecurity#2352 Needed to refactor the target_id code paths to allow this to be used in env printing and sourcing. Signed-off-by: hjenkins <henry@henryjenkins.name>

Andreagit97 · 2023-08-31T09:22:07Z

rebased to fix the CI

FedeDP

/approve

poiana · 2023-08-31T10:09:19Z

LGTM label has been added.

Details

Git tree hash: fc82e5c7f360cf45041dbfe788a5a856530ad4d3

poiana · 2023-08-31T10:09:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, steakunderscore

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

poiana added release-note kind/bug dco-signoff: no labels Jan 12, 2023

poiana requested review from FedeDP and Kaizhe January 12, 2023 17:18

poiana added the size/L label Jan 12, 2023

steakunderscore force-pushed the 2352-source-only branch from a23fc7b to 07fe960 Compare January 12, 2023 17:20

poiana added dco-signoff: yes and removed dco-signoff: no labels Jan 12, 2023

poiana added this to the 0.34.0 milestone Jan 12, 2023

poiana modified the milestones: 0.34.0, 0.35.0 Jan 26, 2023

poiana added dco-signoff: no do-not-merge/contains-merge-commits and removed dco-signoff: yes labels Jan 30, 2023

steakunderscore force-pushed the 2352-source-only branch from 15bd6b2 to db89beb Compare January 30, 2023 12:30

poiana removed the do-not-merge/contains-merge-commits label Jan 30, 2023

steakunderscore force-pushed the 2352-source-only branch from db89beb to 102be77 Compare January 30, 2023 12:32

poiana removed the dco-signoff: no label Jan 30, 2023

poiana added the lifecycle/rotten label Jun 2, 2023

poiana removed the lifecycle/rotten label Jun 22, 2023

FedeDP approved these changes Aug 31, 2023

View reviewed changes

poiana assigned FedeDP Aug 31, 2023

poiana added the lgtm label Aug 31, 2023

poiana added the approved label Aug 31, 2023

Andreagit97 approved these changes Aug 31, 2023

View reviewed changes

poiana assigned Andreagit97 Aug 31, 2023

Andreagit97 closed this Aug 31, 2023

poiana reopened this Aug 31, 2023

fix(scripts): falco-driver-loader add print env

8859874

Fixes falcosecurity#2352 Needed to refactor the target_id code paths to allow this to be used in env printing and sourcing. Signed-off-by: hjenkins <henry@henryjenkins.name>

Andreagit97 force-pushed the 2352-source-only branch from 102be77 to 8859874 Compare August 31, 2023 09:21

poiana removed the lgtm label Aug 31, 2023

poiana requested review from Andreagit97 and FedeDP August 31, 2023 09:21

FedeDP approved these changes Aug 31, 2023

View reviewed changes

poiana added the lgtm label Aug 31, 2023

poiana merged commit 63ba159 into falcosecurity:master Aug 31, 2023

This was referenced Feb 27, 2026

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#6

Closed

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#11

Merged

Conversation

steakunderscore commented Jan 12, 2023 • edited by FedeDP Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

poiana commented Jan 12, 2023

Uh oh!

ggilligan12 commented Jan 12, 2023

Uh oh!

jasondellaluce commented Jan 12, 2023

Uh oh!

FedeDP commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steakunderscore commented Jan 13, 2023

Uh oh!

FedeDP commented Jan 13, 2023

Uh oh!

leogr commented Jan 13, 2023

Uh oh!

steakunderscore commented Jan 13, 2023

Uh oh!

FedeDP commented Jan 16, 2023

Uh oh!

leogr commented Jan 23, 2023

Uh oh!

leogr commented Jan 26, 2023

Uh oh!

leogr commented Jun 22, 2023

Uh oh!

leogr commented Jun 22, 2023

Uh oh!

therealbobo commented Jun 22, 2023

Uh oh!

FedeDP commented Jun 22, 2023

Uh oh!

FedeDP left a comment

Choose a reason for hiding this comment

Uh oh!

poiana commented Aug 31, 2023

Uh oh!

Andreagit97 left a comment

Choose a reason for hiding this comment

Uh oh!

Andreagit97 commented Aug 31, 2023

Uh oh!

poiana commented Aug 31, 2023

Uh oh!

Andreagit97 commented Aug 31, 2023

Uh oh!

FedeDP left a comment

Choose a reason for hiding this comment

Uh oh!

poiana commented Aug 31, 2023

Uh oh!

poiana commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

steakunderscore commented Jan 12, 2023 •

edited by FedeDP

Loading

FedeDP commented Jan 13, 2023 •

edited

Loading