new: configure syscall buffer dimension from Falco#2214
new: configure syscall buffer dimension from Falco#2214poiana merged 5 commits intofalcosecurity:masterfrom
Conversation
FedeDP
left a comment
There was a problem hiding this comment.
Left a comment; otherwise this LGTM!
leogr
left a comment
There was a problem hiding this comment.
This looks great.
I've just left some suggestions (nitpicking 😸)
|
LGTM label has been added. DetailsGit tree hash: 5c95ce7172deeca86625ee937bbb3f6d92d7354a |
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it> Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Co-authored-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
improve also some logs for `m_syscall_buf_size_preset` configuration errors Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it> Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
7e8bf42 to
69031bf
Compare
|
Rebased on actual master just to have this fix #2215 |
|
/milestone 0.33.0 |
|
LGTM label has been added. DetailsGit tree hash: 450a6f8a38ed518bcd8fc9921aa2ee755470b0e0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
As discussed in various places (#2164 (comment), #2164 (comment), #2208) this PR adds the possibility to change the syscall buffer dimension through the Falco configuration file.
The approach used is the one described here #2208 (comment). Users will have an array of indexes that map to precise buffer dimensions in bytes. You can find more information in the
falco.yamlfile, but just for simplicity I report them here:I added also a new command line option
--page-sizeto let the user easily obtain the page size of their systemIf you have any suggestions I'm all ears :)
Which issue(s) this PR fixes:
Fixes #2208
Special notes for your reviewer:
Does this PR introduce a user-facing change?: