Build Falco on ppc64le #1225

sarveshtamba · 2020-05-20T06:40:30Z

Signed-off-by: sarveshtamba [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it: Support to build Falco on ppc64le.

Which issue(s) this PR fixes: Support to build Falco on ppc64le.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support to build Falco on ppc64le.

poiana · 2020-05-20T06:44:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sarveshtamba · 2020-05-20T06:51:18Z

/assign @fntlnz

fntlnz

Hi! Thanks for getting this in line, having ppc64le sounds exciting to us :)

Looking at this PR, seems that the relevant changes to build on ppc64le are in the CMake files, however the PR contains a lot of unrelated changes in other files that are probably the effect of some messed up rebase.

Please let me know how I can help

fntlnz · 2020-06-05T09:28:02Z

Once this is ready, I think that we can add a test runner for docker using --platform=linux/ppc64le in order to let our test run for ppc too.

Signed-off-by: sarveshtamba <[email protected]>

Signed-off-by: Amit Shirodkar <[email protected]> revert changes in falco-driver-loader for build on ppc64le Signed-off-by: Amit Shirodkar <[email protected]>

fntlnz · 2020-06-24T13:44:08Z

CMakeLists.txt

-  INSTALL_COMMAND "")
-
+if("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ppc64le")
+  ExternalProject_Add(


I love how you used moonjit here. I think this is worth discussing in the community call to see if we can just use moonjit for everything at this point. I'm adding a discussion point for today.

I'm trying to understand why we need to use moonjit here and consolidate if there's a valid reason.

I see that luait is still maintained despite what they say on the moonjit page.

fntlnz · 2020-06-24T13:45:07Z

cmake/modules/sysdig-repo/CMakeLists.txt

+    URL "https://github.com/draios/sysdig/archive/${SYSDIG_VERSION}.tar.gz"
+    # URL_HASH SHA256=bd09607aa8beb863db07e695863f7dc543e2d39e7153005759d26a340ff66fa5
+    # we need to change the case of the luaL_reg to luaL_Reg since we are using Moonjit
+    PATCH_COMMAND sed -i "s/luaL_reg/luaL_Reg/g" ${SYSDIG_SOURCE_DIR}/userspace/libsinsp/chisel.cpp && sed -i "s/luaL_reg/luaL_Reg/g" ${SYSDIG_SOURCE_DIR}/userspace/libsinsp/lua_parser.cpp && sed -i "s/luaL_getn/lua_objlen /g" ${SYSDIG_SOURCE_DIR}/userspace/libsinsp/lua_parser_api.cpp


The only thing that changes here is the patch command.

I think it's better if we just do the if for the patch command and not for the whole external project.

krisnova · 2020-06-24T15:36:26Z

Next steps:

@sarveshtamba

Test moonjit vs raptorjit for the Power PC use case
- Does it work with both?
- Does it work with only moonjit?

@fntlnz

Test moonjit with CircleCI to see if the tests pass/fail

shirodkara · 2020-07-07T12:18:09Z

Next steps:

@sarveshtamba

* Test moonjit vs raptorjit for the Power PC use case
  
  * Does it work with both?
  * Does it work with only moonjit?

@kris-nova @fntlnz I wasn't able to build raptorjit on PowerPC , so on power, falco builds only with moonjit.

fntlnz · 2020-08-13T17:07:42Z

I tested this and works very well. Moonjit is the right option in my opinion.

poiana · 2020-11-25T15:15:37Z

@sarveshtamba: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leodido · 2021-04-09T08:43:52Z

/milestone 0.28.1

poiana · 2021-12-27T15:51:07Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

jasondellaluce · 2022-01-19T15:09:08Z

/milestone 0.32.0

poiana · 2022-02-18T22:08:31Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana · 2022-03-20T23:42:05Z

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

poiana · 2022-03-20T23:42:08Z

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sarveshtamba mentioned this pull request May 20, 2020

PR to build Falco on ppc64le. #1220

Closed

poiana added release-note kind/feature dco-signoff: yes area/build labels May 20, 2020

poiana requested review from krisnova and mstemm May 20, 2020 06:43

poiana added the size/XXL label May 20, 2020

poiana assigned fntlnz May 20, 2020

fntlnz reviewed Jun 4, 2020

View reviewed changes

poiana added size/M do-not-merge/contains-merge-commits dco-signoff: no and removed size/XXL dco-signoff: yes labels Jun 16, 2020

shirodkara force-pushed the master branch from 1990b6d to 34579e4 Compare June 16, 2020 09:53

sarveshtamba and others added 2 commits June 16, 2020 12:41

Build Falco on ppc64le

3d13ab0

Signed-off-by: sarveshtamba <[email protected]>

revert changes in falco-driver-loader for build on ppc4le

94fe95b

Signed-off-by: Amit Shirodkar <[email protected]> revert changes in falco-driver-loader for build on ppc64le Signed-off-by: Amit Shirodkar <[email protected]>

shirodkara force-pushed the master branch from 34579e4 to 94fe95b Compare June 16, 2020 12:45

poiana added dco-signoff: yes and removed do-not-merge/contains-merge-commits dco-signoff: no labels Jun 16, 2020

fntlnz reviewed Jun 24, 2020

View reviewed changes

fntlnz mentioned this pull request Jun 26, 2020

Code changes to support ppc64le platform #932

Closed

leogr added this to the 0.26.0 milestone Aug 25, 2020

krisnova modified the milestones: 0.26.0, 0.27.0 Sep 24, 2020

fntlnz mentioned this pull request Oct 13, 2020

Falco to build on aarch64 #1442

Merged

4 tasks

poiana added the needs-rebase label Nov 25, 2020

fntlnz modified the milestones: 0.27.0, 0.28.0 Jan 15, 2021

poiana modified the milestones: 0.28.0, 0.28.1 Apr 9, 2021

leogr modified the milestones: 0.28.1, 0.29.0 Apr 26, 2021

leogr modified the milestones: 0.29.0, 0.30.0 Jun 17, 2021

fntlnz removed their assignment Aug 30, 2021

leogr modified the milestones: 0.30.0, 0.31.0 Sep 28, 2021

poiana added the lifecycle/stale label Dec 27, 2021

poiana modified the milestones: 0.31.0, 0.32.0 Jan 19, 2022

poiana added lifecycle/rotten and removed lifecycle/stale labels Feb 18, 2022

poiana closed this Mar 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Falco on ppc64le #1225

Build Falco on ppc64le #1225

sarveshtamba commented May 20, 2020

poiana commented May 20, 2020

sarveshtamba commented May 20, 2020

fntlnz left a comment

fntlnz commented Jun 5, 2020

fntlnz Jun 24, 2020

fntlnz Jun 24, 2020

fntlnz Jun 24, 2020

krisnova commented Jun 24, 2020

shirodkara commented Jul 7, 2020

fntlnz commented Aug 13, 2020

poiana commented Nov 25, 2020

leodido commented Apr 9, 2021

poiana commented Dec 27, 2021

jasondellaluce commented Jan 19, 2022

poiana commented Feb 18, 2022

poiana commented Mar 20, 2022

poiana commented Mar 20, 2022

Build Falco on ppc64le #1225

Build Falco on ppc64le #1225

Conversation

sarveshtamba commented May 20, 2020

poiana commented May 20, 2020

sarveshtamba commented May 20, 2020

fntlnz left a comment

Choose a reason for hiding this comment

fntlnz commented Jun 5, 2020

fntlnz Jun 24, 2020

Choose a reason for hiding this comment

fntlnz Jun 24, 2020

Choose a reason for hiding this comment

fntlnz Jun 24, 2020

Choose a reason for hiding this comment

krisnova commented Jun 24, 2020

shirodkara commented Jul 7, 2020

fntlnz commented Aug 13, 2020

poiana commented Nov 25, 2020

leodido commented Apr 9, 2021

poiana commented Dec 27, 2021

jasondellaluce commented Jan 19, 2022

poiana commented Feb 18, 2022

poiana commented Mar 20, 2022

poiana commented Mar 20, 2022