Skip to content
This repository was archived by the owner on Jul 28, 2022. It is now read-only.

update: align protobufs to latest changes#44

Merged
poiana merged 2 commits intofalcosecurity:masterfrom
jasondellaluce:update-protos-tags
Sep 29, 2021
Merged

update: align protobufs to latest changes#44
poiana merged 2 commits intofalcosecurity:masterfrom
jasondellaluce:update-protos-tags

Conversation

@jasondellaluce
Copy link
Contributor

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area api

/area client

What this PR does / why we need it:
This updates the protobufs the the latest version supported in Falco, following up the recent updates of falcosecurity/falco#1714 that included the tags field in the output service. The test cases have been updated accordingly.

Does this PR introduce a user-facing change?:

update: align protobufs to latest changes

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@poiana
Copy link

poiana commented Sep 24, 2021

Welcome @jasondellaluce! It looks like this is your first PR to falcosecurity/client-py 🎉

@poiana poiana added the size/L label Sep 24, 2021
@mmat11
Copy link
Contributor

mmat11 commented Sep 24, 2021

engine_version and engine_fields_checksum are missing here. Also, the Source enum should be updated aswell

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce
Copy link
Contributor Author

engine_version and engine_fields_checksum are missing here. Also, the Source enum should be updated aswell

Thank you for your suggestion! I pushed a new commit with these updates.

@mmat11
Copy link
Contributor

mmat11 commented Sep 29, 2021

Thank you for your suggestion! I pushed a new commit with these updates.

lgtm!

@poiana
Copy link

poiana commented Sep 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Sep 29, 2021

LGTM label has been added.

DetailsGit tree hash: 05df2778919a6b9445ed225667354fff23f9de41

@poiana poiana merged commit bdd615f into falcosecurity:master Sep 29, 2021
@jasondellaluce jasondellaluce deleted the update-protos-tags branch September 29, 2021 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants