update: generate protobufs with tags field support and fix makefile

[jasondellaluce]

What type of PR is this?

/kind bug

/kind feature

Any specific area of the project related to this PR?

/area api

/area makefile

What this PR does / why we need it:
This PR contributes with the following:

• Updates the generated protobufs and grpc stubs following the changes of new(outputs): expose rule tags and event source in gRPC and json outputs falco#1714, that adds support to tags in the outputs services.
• Updates the version of the modules in go.mod.
• Fixes a building issue caused by our current Makefile.

Which issue(s) this PR fixes:
Fixes #54

Does this PR introduce a user-facing change?:

update: generate protobufs with tags field support and fix makefile

[poiana]

@jasondellaluce: The label(s) area/makefile cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind bug

/kind feature

Any specific area of the project related to this PR?

/area api

/area makefile

What this PR does / why we need it:
This PR contributes with the following:

• Updates the generated protobufs and grpc stubs following the changes of new(outputs): expose rule tags and event source in gRPC and json outputs falco#1714, that adds support to tags in the outputs services.
• Updates the version of the modules in go.mod.
• Fixes a building issue caused by our current Makefile.

Which issue(s) this PR fixes:
Fixes #54

Does this PR introduce a user-facing change?:

update: generate protobufs with tags field support and fix makefile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[poiana]

Welcome @jasondellaluce! It looks like this is your first PR to falcosecurity/client-go 🎉

[leodido]

PR changes look good to me.

The only thing I'm not getting is why the file names are different now.

Can we keep the file names of the generated *.pb.go the same as before?
Ie., pkg/api/outputs/outputs.pb.go rather than the new pkg/api/outputs/output_grpc.pb.go

[jasondellaluce]

Thank you for your review!

This is caused by the changes at: https://github.com/falcosecurity/client-go/pull/55/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R35

From my understanding, it seems like the "new way" is to generate two separate files, one containing the gRPC service definitions (_grpc.pb.go) and one containing the protobuf message information (.pb.go). This is due to the fact the two files are now generated by two distinct tools, protoc-gen-go-grpc and protoc-gen-go respectively. This is documented in this release note: https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.20.0#v1.20-grpc-support

gRPC support
The v1.20 protoc-gen-go does not support generating gRPC service definitions. In the future, gRPC service generation will be supported by a new protoc-gen-go-grpc plugin provided by the Go gRPC project.
The github.com/golang/protobuf version of protoc-gen-go continues to support gRPC and will continue to do so for the foreseeable future.

This topic is also related to the error of #54, which currently breaks our make setup in newer versions of protoc.

--go_out: protoc-gen-go: plugins are not supported; use 'protoc --go-grpc_out=...' to generate gRPC

[leodido]

Oh, I see. They split the services out. Gotcha!

/lgtm

[poiana]

LGTM label has been added.

Details

Git tree hash: 8b1042c0f87c65ddfe847157d3023ed5329f7d13

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment