perf: undo ASGI cythonization #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1860 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 5218 5218
Branches 842 842
=========================================
Hits 5218 5218 Continue to review full report at Codecov.
|
CaselIT
approved these changes
Feb 10, 2021
kgriffs
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sad having to resort to this, but it seems that cythonized coroutines, although reasonably sped up as if added directly to an async loop, suffer a severe performance hit when
awaited from a Python coroutine (and that is what virtually all ASGI app servers out there seem to do). So much that performance deteriorates to worse than pure Python 😬Cython 3.0 alpha shows slighty better results, but still not even demonstrably faster than the pure Python version.