Rename Faker::show to Faker::Theater

[keshavbiswa]

This Pull Request has been created because of naming issues identified here: #2787

This PR replaces the usage of Faker::Show to be Faker::Theater for the following reasons:

The file was created under faker/music/show.rb but the class definition is Faker::Show At the very least the class should be name-spaced correctly as Faker::Music::Show

Faker::Show is ambiguous for its current usage. Faker::Music::Show would also be ambiguous. The class supports three methods: adult_musical kids_musical play that generate names for musicals and plays which all can be categorized under Theater.

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #]
• Tests are added or updated if you fix a bug, refactor something, or add a feature.
• Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

• Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
• You've reviewed and followed the Contributing guidelines.

[keshavbiswa]

@stefannibrasil Please review :)

[stefannibrasil]

Thank you! One small ask: could you rewrite the commit message with the details from the original PR:

This Pull Request has been created because of naming issues identified here: https://github.com/faker-ruby/faker/issues/2787

This PR replaces the usage of Faker::Show to be Faker::Theater for the following reasons:

The file was created under faker/music/show.rb but the class definition is Faker::Show At the very least the class should be name-spaced correctly as Faker::Music::Show

Faker::Show is ambiguous for its current usage. Faker::Music::Show would also be ambiguous. The class supports three methods: adult_musical kids_musical play that generate names for musicals and plays which all can be categorized under Theater.

It helps with tracking down what was the reason behind the change.

[keshavbiswa]

Thank you! One small ask: could you rewrite the commit message with the details from the original PR:

This Pull Request has been created because of naming issues identified here: https://github.com/faker-ruby/faker/issues/2787

This PR replaces the usage of Faker::Show to be Faker::Theater for the following reasons:

The file was created under faker/music/show.rb but the class definition is Faker::Show At the very least the class should be name-spaced correctly as Faker::Music::Show

Faker::Show is ambiguous for its current usage. Faker::Music::Show would also be ambiguous. The class supports three methods: adult_musical kids_musical play that generate names for musicals and plays which all can be categorized under Theater.

It helps with tracking down what was the reason behind the change.

Do you mean the commit message or the PR description?

[keshavbiswa]

@stefannibrasil I have updated the PR description for it. Let me know if you need me to rewrite the commit message as well.

[stefannibrasil]

@stefannibrasil I have updated the PR description for it. Let me know if you need me to rewrite the commit message as well.

the commit message is better, thanks!

[keshavbiswa]

@stefannibrasil Can we merge this?

[stefannibrasil]

thanks ⭐

[stefannibrasil]

Good catch!