Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2786] Fix umlaut issue in opera. #2793

Conversation

sudeeptarlekar
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar commented Jul 2, 2023

Motivation / Background

This is classic issue of umlauts. This PR fixes the umlaut in the one of the yaml file.

Resolves: #2786

Additional information

Test cases are written but they are not valid, fixed test cases around this feature as well.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

This is classic case of umalut issue.
Fixed the umlaut in the yml file and fixed the test cases around it.

fixes: 2786
@sudeeptarlekar sudeeptarlekar force-pushed the bug/2786/issue-in-music-opera branch from dc53742 to 6e9cc48 Compare July 2, 2023 10:26
@sudeeptarlekar
Copy link
Contributor Author

sudeeptarlekar commented Jul 2, 2023

@psibi, @koic, @Zeragamba, @vbrazo can you pls review this?

Thanks in advance

@thdaraujo
Copy link
Contributor

thanks, but this was already solved by #2792

@thdaraujo thdaraujo closed this Jul 5, 2023
@sudeeptarlekar sudeeptarlekar deleted the bug/2786/issue-in-music-opera branch December 1, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to call Faker::Music::Opera.saint_saens fails
2 participants