-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add train station generator #2755
Add train station generator #2755
Conversation
…tly testing well for UK stations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks for working on this! Left a few questions.
…ated main README.md and set up train_station.md in docs
…sensitivity added / refactored
…ocs and restructured the code to correspond
For the Travel > TrainStations faker:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff, thanks for changing the code!
LGTM overall, but I left a few comments. I think we should keep it simple and not downcase the types and regions for now.
…inputs_with_samples method and moved into private with #validate_arguments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Motivation / Background
Currently, Faker doesn't have a train station generator, and this can be a problem for testing location-based applications or data pipelines that deal with transit data. Having a train station generator would add value to the Faker library and allow for more comprehensive testing of these types of applications.
Additional information
One alternative to adding a new train station generator would be to manually create a list of station names and use them in tests. However, this can be time-consuming and may not provide enough variety in the generated data.
Another alternative would be to use an external library or API to generate train station names, but this would add an additional dependency to the project and may not integrate well with Faker.