Add Faker::Company.department generator #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Companies often include departments (e.g., "Information Technology), so this adds a few common department names to the Company generator. - All examples are strings with a few having '/' as well. Example: `Faker::Company.department #=> "Information Technology"`:
thdaraujo
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Thanks for your contribution!
Do you mind updating the docs? https://github.com/faker-ruby/faker/blob/main/doc/default/company.md
lib/faker/default/company.rb
Outdated
| # @example | ||
| # Faker::Company.department #=> "Information Technology" | ||
| # | ||
| # @faker.version 1.6.0 |
There was a problem hiding this comment.
Version needs to be marked as next as documented here: https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yard-docs
|
Updated to include documentation and a revised version. Thank you for the feedback! |
stefannibrasil
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Companies often include departments (e.g., "Information Technology"), so this adds a few common department names to the Company generator.
All examples are strings, with a few having '/'.
Example