Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude_words keyword to Lorem Ipsum to prevent words from being produced #2665

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

philipfong
Copy link
Contributor

Add new keyword argument that excludes lorem ipsum words from being produced

Summary

This addresses issue # 2663 in the faker ruby repository here: #2663

…sum words from being produced

fix(faker-2663): remove pry

fix(faker-2663): linting

fix(faker-2663): use instance_of and self assignment

fix(faker-2663): use instance_of? for Array

feat(faker-2663): allow for comma delimited string to be passed
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would let @stefannibrasil also take a look.

@psibi psibi merged commit ba5cea0 into faker-ruby:main Dec 27, 2022
@psibi psibi mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants