add digits to password (#2705)

faker-ruby · Mar 29, 2023 · 36cd382 · 36cd382
1 parent 4d52bc1
commit 36cd382
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/faker/default/internet.rb b/lib/faker/default/internet.rb
@@ -174,6 +174,10 @@ def password(min_length: 8, max_length: 16, mix_case: true, special_characters:
         password << lower_chars[rand(lower_chars.count - 1)]
         character_bag += lower_chars
 
+        digits = ('1'..'9').to_a
+        password << digits[rand(digits.count - 1)]
+        character_bag += digits
+
         if character_types.include?(:mix_case)
           upper_chars = ('A'..'Z').to_a
           password << upper_chars[rand(upper_chars.count - 1)]

diff --git a/test/faker/default/test_faker_internet.rb b/test/faker/default/test_faker_internet.rb
@@ -117,7 +117,12 @@ def test_username_with_range_and_separators
   end
 
   def test_password
-    assert_match(/\w{3}/, @tester.password)
+    password = @tester.password
+
+    assert_match(/\w{3}/, password)
+    assert_match(/\d/, password)
+    assert_match(/[a-z]/, password)
+    assert_match(/[A-Z]/, password)
   end
 
   def test_password_with_integer_arg