Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): remove Pizza from Greek words #2908

Merged
merged 3 commits into from
May 22, 2024
Merged

fix(locale): remove Pizza from Greek words #2908

merged 3 commits into from
May 22, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 18, 2024

It is the only word that uses lain characters and according to google translate it has a different translation.

https://translate.google.com/?sl=en&tl=el&text=Pizza&op=translate

I removed it instead of translating it because I'm not familiar with Greek.

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent c: locale Permutes locale definitions m: commerce Something is referring to the commerce module labels May 18, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 18, 2024
@ST-DDT ST-DDT requested review from a team May 18, 2024 09:30
@ST-DDT ST-DDT self-assigned this May 18, 2024
Copy link

netlify bot commented May 18, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit baf8e31
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/664e24d8c65fdb0008508c0d
😎 Deploy Preview https://deploy-preview-2908.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (d9dd194) to head (b81b40b).

Current head b81b40b differs from pull request most recent head baf8e31

Please upload reports for the commit baf8e31 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2908      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2977     2977              
  Lines      215422   215421       -1     
  Branches      950      948       -2     
==========================================
- Hits       215338   215333       -5     
- Misses         84       88       +4     
Files Coverage Δ
src/locales/el/commerce/product_name.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team May 18, 2024 18:38
@ST-DDT ST-DDT enabled auto-merge (squash) May 22, 2024 17:01
@ST-DDT ST-DDT merged commit 80b4a23 into next May 22, 2024
18 checks passed
@ST-DDT ST-DDT deleted the locale/el/commerce branch May 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants