Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): normalize music data #2857

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265

Normalize the entries in the music module definitions in all locales.

I choose this module as locale data are still limited. additionally, no data set exceedes the 1k entry limit, so all locale file changes are based on entry sorting.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: music Something is referring to the music module labels Apr 28, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 28, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team April 28, 2024 14:40
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 28, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner April 28, 2024 14:40
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit de6cd7a
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662f4b18e3a4510008c526c8
😎 Deploy Preview https://deploy-preview-2857.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@1a21296). Click here to learn what that means.

❗ Current head 55f0d56 differs from pull request most recent head de6cd7a. Consider uploading reports for the commit de6cd7a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2857   +/-   ##
=======================================
  Coverage        ?   99.96%           
=======================================
  Files           ?     2973           
  Lines           ?   212501           
  Branches        ?      597           
=======================================
  Hits            ?   212422           
  Misses          ?       79           
  Partials        ?        0           
Files Coverage Δ
src/locales/en/music/genre.ts 100.00% <100.00%> (ø)
src/locales/en/music/song_name.ts 100.00% <100.00%> (ø)
src/locales/fa/music/genre.ts 100.00% <100.00%> (ø)
src/locales/fr/music/genre.ts 100.00% <100.00%> (ø)
src/locales/he/music/genre.ts 100.00% <100.00%> (ø)
src/locales/ur/music/genre.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/music/genre.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/music/song_name.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT requested review from a team April 28, 2024 22:25
@ST-DDT ST-DDT enabled auto-merge (squash) April 29, 2024 07:24
@ST-DDT ST-DDT merged commit 425e10f into next Apr 29, 2024
18 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/normalize-music-data branch May 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: music Something is referring to the music module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants