Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): misc spelling errors in commerce & food #2809

Merged
merged 2 commits into from
Apr 14, 2024
Merged

fix(locale): misc spelling errors in commerce & food #2809

merged 2 commits into from
Apr 14, 2024

Conversation

matthewmayer
Copy link
Contributor

  • Jewelery is neither standard US or British spelling. Should be Jewelry or Jewellery
  • Peach had an accidental e
  • i think Quark and Quince were accidentally merged to one line

@matthewmayer
fix: misc spelling errors in commerce & food
076b028 
- Jewelery is neither standard US or British spelling. Should be Jewelry or Jewellery
- Peach had an accidental e
- i think Quark and Quince were accidentally merged to one line
@matthewmayer matthewmayer requested a review from a team as a code owner April 12, 2024 08:01
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited

✅ Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit fac411c
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/661c529df0560c0008468fc1

@codecov Codecov
Copy link

codecov bot commented Apr 12, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (1b62083) to head (fac411c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2809      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2971     2971              
  Lines      212619   212620       +1     
  Branches      601      948     +347     
==========================================
  Hits       212542   212542              
- Misses         77       78       +1
Files Coverage Δ
src/locales/en/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/en/food/fruit.ts 100.00% <100.00%> (ø)
src/locales/en/food/ingredient.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Apr 12, 2024
@matthewmayer matthewmayer added p: 1-normal Nothing urgent m: commerce Something is referring to the commerce module m: food Something is referring to the food module labels Apr 12, 2024
@ST-DDT ST-DDT requested review from a team April 12, 2024 12:24
@ST-DDT ST-DDT added this to the vAnytime milestone Apr 12, 2024
@ST-DDT ST-DDT added the c: locale Permutes locale definitions label Apr 12, 2024
@ST-DDT ST-DDT changed the title fix: misc spelling errors in commerce & food fix(locale): misc spelling errors in commerce & food Apr 14, 2024
@ST-DDT ST-DDT enabled auto-merge (squash) April 14, 2024 22:03
@ST-DDT ST-DDT merged commit 734a7f3 into faker-js:next Apr 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: commerce Something is referring to the commerce module m: food Something is referring to the food module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewmayer @ST-DDT @import-brain @xDivisionByZerox