Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle): Make VIN number generation more accurate #2765

Merged
merged 7 commits into from
Apr 26, 2024
Merged

fix(vehicle): Make VIN number generation more accurate #2765

merged 7 commits into from
Apr 26, 2024

Conversation

lulunac27a
Copy link
Contributor

The last six digits of VIN (vehicle identification number) is the number and the 13th digit (last five digits) can start with number 0 (zero).

The last six digits of VIN (vehicle identification number) is the number and the 13th digit (last five digits) can start with number 0 (zero).
@lulunac27a lulunac27a requested a review from a team as a code owner March 23, 2024 02:20
Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 30a7d80
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662ac58fe9b0d50008a87ccf
😎 Deploy Preview https://deploy-preview-2765.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/modules/vehicle/index.ts Outdated Show resolved Hide resolved
Fix code mistake
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent m: vehicle Something is referring to the vehicle module labels Mar 23, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Mar 23, 2024
@xDivisionByZerox
Copy link
Member

@faker-js/maintainers Is this a refactor or a fix?

@xDivisionByZerox xDivisionByZerox requested review from a team March 23, 2024 13:49
@ST-DDT
Copy link
Member

ST-DDT commented Mar 23, 2024

@faker-js/maintainers Is this a refactor or a fix?

IMO fix

@xDivisionByZerox xDivisionByZerox added the c: bug Something isn't working label Mar 23, 2024
@xDivisionByZerox xDivisionByZerox changed the title refactor(vehicle): Make VIN number generation more accurate fix(vehicle): Make VIN number generation more accurate Mar 23, 2024
@Shinigami92
Copy link
Member

@xDivisionByZerox xDivisionByZerox dismissed their stale review April 25, 2024 20:17

Was in wrong tab

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (16ba43a) to head (30a7d80).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2765      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.02%     
==========================================
  Files        2973     2973              
  Lines      212501   212501              
  Branches      950      942       -8     
==========================================
- Hits       212429   212405      -24     
- Misses         72       96      +24     
Files Coverage Δ
src/modules/vehicle/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@xDivisionByZerox xDivisionByZerox requested a review from a team April 25, 2024 21:07
@ST-DDT ST-DDT requested review from matthewmayer and a team April 25, 2024 22:56
@ST-DDT ST-DDT merged commit 1f7568a into faker-js:next Apr 26, 2024
20 checks passed
@faker-js faker-js deleted a comment Apr 26, 2024
@lulunac27a lulunac27a deleted the patch-1 branch April 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants