fix(finance): correct VG IBAN format #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexnagel
changed the title
ST-DDT
added
c: bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2552 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 2805 2805
Lines 250069 250069
Branches 1101 1100 -1
=======================================
+ Hits 249004 249008 +4
+ Misses 1037 1033 -4
Partials 28 28
|
ST-DDT
approved these changes
Nov 18, 2023
4 tasks
|
I also created a PR in validatorjs to propagate the validation upstream: |
ST-DDT
changed the title
matthewmayer
approved these changes
Nov 18, 2023
xDivisionByZerox
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current generated Virgin Islands IBAN format is invalid. It generates an invalid bank code.
VG46H07Y0223060094359858 The bold part should be 4 non numeric characters.
See below links for the correct format:
https://www.mobilefish.com/services/random_iban_generator/random_iban_generator.php
https://wise.com/gb/iban/british-virgin-islands