Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add person to fr_SN #2537

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Conversation

makhtar-sarr
Copy link
Contributor

In this PR I add the first and last names of the most common girls and boys in Senegal.

female_first_name.ts: https://namiiz.com/girl/categories:11-48
male_first_name.ts: https://namiiz.com/boy/categories:11-48
last_name.ts: https://surnam.es/senegal

@makhtar-sarr makhtar-sarr requested a review from a team as a code owner November 11, 2023 12:46
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #2537 (1d2f992) into next (26f298c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2537      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2794     2801       +7     
  Lines      249473   249842     +369     
  Branches     1083     1082       -1     
==========================================
+ Hits       248425   248786     +361     
- Misses       1020     1028       +8     
  Partials       28       28              
Files Coverage Δ
src/locales/fr_SN/index.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/person/index.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/person/last_name_pattern.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/person/male_first_name.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/person/name.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 12, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 12, 2023
@ST-DDT ST-DDT changed the title feat(locale): Add person to fr_SN feat(locale): add person to fr_SN Nov 12, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) November 12, 2023 17:42
@ST-DDT ST-DDT merged commit ef965da into faker-js:next Nov 12, 2023
20 checks passed
@makhtar-sarr makhtar-sarr deleted the person-fr_SN branch November 13, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants