Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in usage.md #2502

Merged
merged 1 commit into from
Oct 24, 2023
Merged

docs: fix typo in usage.md #2502

merged 1 commit into from
Oct 24, 2023

Conversation

lacymorrow
Copy link
Contributor

As you can see, your User model probably looks completely different from the one you have in your codebase.

Seems incorrect, should be:

As you can see, our User model probably looks completely different from the one you have in your codebase.

@lacymorrow lacymorrow requested a review from a team October 23, 2023 17:23
@lacymorrow lacymorrow requested a review from a team as a code owner October 23, 2023 17:23
@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 23, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team October 23, 2023 17:35
@xDivisionByZerox xDivisionByZerox changed the title Typo in usage.md docs: fix typo in usage.md Oct 23, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Your effort, no matter how small, is greatly appreciated and will make a difference for some developers. ❤️

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2502 (b40b682) into next (c970ca0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2502      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255520   255520              
  Branches     1103     1102       -1     
==========================================
- Hits       254476   254461      -15     
- Misses       1016     1031      +15     
  Partials       28       28              

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added this to the vAnytime milestone Oct 23, 2023
@lacymorrow
Copy link
Contributor Author

Lol this one is on the smaller.

@ST-DDT ST-DDT merged commit 79c0f25 into faker-js:next Oct 24, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants