Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): da data for date, phone, internet #2389

Merged
merged 3 commits into from
Sep 15, 2023
Merged

feat(locale): da data for date, phone, internet #2389

merged 3 commits into from
Sep 15, 2023

Conversation

stonor
Copy link
Contributor

@stonor stonor commented Sep 11, 2023

No description provided.

@stonor stonor requested a review from a team as a code owner September 11, 2023 08:17
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #2389 (b2e3197) into next (cd277e2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2389    +/-   ##
========================================
  Coverage   99.61%   99.61%            
========================================
  Files        2785     2793     +8     
  Lines      251462   251568   +106     
  Branches     1095     1097     +2     
========================================
+ Hits       250483   250600   +117     
+ Misses        952      941    -11     
  Partials       27       27
Files Changed Coverage Δ
src/locales/da/date/index.ts 100.00% <100.00%> (ø)
src/locales/da/date/month.ts 100.00% <100.00%> (ø)
src/locales/da/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/da/index.ts 100.00% <100.00%> (ø)
src/locales/da/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/da/internet/free_email.ts 100.00% <100.00%> (ø)
src/locales/da/internet/index.ts 100.00% <100.00%> (ø)
src/locales/da/phone_number/formats.ts 100.00% <100.00%> (ø)
src/locales/da/phone_number/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: date Something is referring to the date module m: internet Something is referring to the internet module m: phone Something is referring to the phone module labels Sep 11, 2023
@ST-DDT ST-DDT requested review from a team September 11, 2023 20:39
@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) September 14, 2023 19:21
@xDivisionByZerox xDivisionByZerox merged commit cb33664 into faker-js:next Sep 15, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@stonor stonor

Labels
c: locale Permutes locale definitions m: date Something is referring to the date module m: internet Something is referring to the internet module m: phone Something is referring to the phone module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
5 participants
@stonor @matthewmayer @ST-DDT @xDivisionByZerox @Shinigami92