Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(finance): remove defunct credit card issuers #2356

Merged
merged 3 commits into from
Sep 5, 2023
Merged

chore(finance): remove defunct credit card issuers #2356

merged 3 commits into from
Sep 5, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #2344

@matthewmayer matthewmayer requested a review from a team as a code owner August 29, 2023 01:37
@matthewmayer matthewmayer self-assigned this Aug 29, 2023
@matthewmayer matthewmayer added m: finance Something is referring to the finance module p: 1-normal Nothing urgent labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #2356 (f959783) into next (869b9b4) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2356   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2774     2770    -4     
  Lines      251780   251751   -29     
  Branches     1086     1087    +1     
=======================================
- Hits       250803   250776   -27     
+ Misses        950      948    -2     
  Partials       27       27
Files Changed Coverage Δ
src/locales/en/finance/credit_card/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

ST-DDT
ST-DDT approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these data only in en or do other locales have them as well?

@ST-DDT ST-DDT requested review from a team August 30, 2023 17:43
@ST-DDT ST-DDT added the c: locale Permutes locale definitions label Aug 30, 2023
@matthewmayer
Copy link
Contributor Author

Only en

@ST-DDT ST-DDT enabled auto-merge (squash) September 5, 2023 06:59
@ST-DDT ST-DDT merged commit 630375b into faker-js:next Sep 5, 2023
36 checks passed
@matthewmayer matthewmayer mentioned this pull request Sep 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Some credit card issuers are defunct
3 participants
@matthewmayer @ST-DDT @import-brain