Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): added word and music to Farsi #2210

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Conversation

atenadadkhah
Copy link
Contributor

Description

This PR adds word and music localizations for Farsi language, which previously didn't exist. Users can now generate realistic and culturally relevant Farsi words and musical data in their applications.

This PR is created based on this issue: #2209

Example Usage

import { fakerFA as faker } from "@faker-js/faker";

// Word
faker.word.noun() // خانه
faker.word.verb() // خواندن
faker.word.adjective() // کوتاه
faker.word.preposition() // از
faker.word.interjection() // وای
faker.word.conjunction() // و


// Music
faker.music.genre() // پاپ

@atenadadkhah atenadadkhah requested a review from a team as a code owner June 12, 2023 13:24
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jun 12, 2023
@ST-DDT ST-DDT linked an issue Jun 12, 2023 that may be closed by this pull request
10 tasks
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #2210 (73c241f) into next (b9008bf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 73c241f differs from pull request most recent head 2c6fbdd. Consider uploading reports for the commit 2c6fbdd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2210      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2607     2616       +9     
  Lines      245002   245425     +423     
  Branches     1150     1149       -1     
==========================================
+ Hits       244012   244431     +419     
- Misses        963      967       +4     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/fa/index.ts 100.00% <100.00%> (ø)
src/locales/fa/music/genre.ts 100.00% <100.00%> (ø)
src/locales/fa/music/index.ts 100.00% <100.00%> (ø)
src/locales/fa/word/adjective.ts 100.00% <100.00%> (ø)
src/locales/fa/word/conjunction.ts 100.00% <100.00%> (ø)
src/locales/fa/word/index.ts 100.00% <100.00%> (ø)
src/locales/fa/word/interjection.ts 100.00% <100.00%> (ø)
src/locales/fa/word/noun.ts 100.00% <100.00%> (ø)
src/locales/fa/word/preposition.ts 100.00% <100.00%> (ø)
src/locales/fa/word/verb.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@import-brain import-brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran words through Google Translate, LGTM

@ST-DDT ST-DDT changed the title feat(locale): Added Word and Music localization support for Farsi language. feat(locale): added word and music to Farsi Jun 16, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) June 16, 2023 19:46
@ST-DDT ST-DDT merged commit 7687511 into faker-js:next Jun 16, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Localization for Farsi/Persian lang doesn't work in faker.word
5 participants