chore: improve nullish-checks in tests (#3081)

faker-js · Sep 9, 2024 · 18ab2c7 · 18ab2c7
1 parent acb8b52
commit 18ab2c7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/test/all-functional.spec.ts b/test/all-functional.spec.ts
@@ -81,7 +81,7 @@ const modules = getMethodNamesByModules(fakerEN);
 describe('BROKEN_LOCALE_METHODS test', () => {
   it('should not contain obsolete configuration (modules)', () => {
     const existingModules = Object.keys(modules);
-    const configuredModules = Object.keys(BROKEN_LOCALE_METHODS ?? {});
+    const configuredModules = Object.keys(BROKEN_LOCALE_METHODS);
     const obsoleteModules = configuredModules.filter(
       (module) => !existingModules.includes(module)
     );

diff --git a/test/support/seeded-runs.ts b/test/support/seeded-runs.ts
@@ -142,8 +142,12 @@ class TestGenerator<
     repetitions: number = 1
   ): void {
     this.setup();
+    const callable = this.module[method];
+    if (callable == null) {
+      throw new Error(`Method ${method} not found in ${this.moduleName}`);
+    }
+
     for (let i = 0; i < repetitions; i++) {
-      const callable = this.module[method];
       const value = callable(...args);
       expect(value).toMatchSnapshot();
     }