Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a logarithm expectation #22

Merged
merged 7 commits into from
Aug 1, 2024
Merged

add a logarithm expectation #22

merged 7 commits into from
Aug 1, 2024

Conversation

Katalam
Copy link
Contributor

@Katalam Katalam commented Jul 29, 2024

No description provided.

@Katalam Katalam mentioned this pull request Jul 29, 2024
@faissaloux faissaloux self-assigned this Jul 29, 2024
@faissaloux faissaloux added the enhancement New feature or request label Jul 29, 2024
src/Expectation.php Outdated Show resolved Hide resolved
@faissaloux
Copy link
Owner

Can you add some tests where $number <= 0 and/or $base <= 0

@faissaloux faissaloux added this to the 1.2.0 milestone Jul 29, 2024
tests/toBeLogarithmOf.php Outdated Show resolved Hide resolved
@faissaloux faissaloux merged commit dda5016 into faissaloux:main Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants