Improve browser detection for Quark #737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Type of Change
Description
This PR improves the detection of Quark browser. Currently, the library may not accurately identify Quark browser user agents. This change adds specific regex patterns for Quark browser and updates the browser detection logic to handle Quark user agents correctly. This improvement is necessary to ensure accurate browser identification for users.
Test
test/specs/browser-all.json
file specifically for Quark browser:Impact
This PR does not introduce any breaking changes. Existing users of UAParser.js should not need to make any changes to their code. The improvement simply enhances the library's ability to detect Quark browsers accurately.
Other Info
N/A