Backport - Fix #747: Python Request mistakenly identified as Meta Quest

(cherry picked from commit 391b808)
faisalman · Dec 21, 2024 · 88fa66d · 88fa66d
1 parent 1665684
commit 88fa66d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/src/ua-parser.js b/src/ua-parser.js
@@ -724,7 +724,16 @@
             ], [MODEL, [VENDOR, GOOGLE], [TYPE, WEARABLE]], [
             /droid.+; (wt63?0{2,3})\)/i
             ], [MODEL, [VENDOR, ZEBRA], [TYPE, WEARABLE]], [
-            /(quest( \d| pro)?)/i                                               // Oculus Quest
+
+            ///////////////////
+            // XR
+            ///////////////////
+
+            /droid.+; (glass) \d/i                                              // Google Glass
+            ], [MODEL, [VENDOR, GOOGLE], [TYPE, WEARABLE]], [
+            /(pico) (4|neo3(?: link|pro)?)/i                                    // Pico
+            ], [VENDOR, MODEL, [TYPE, WEARABLE]], [
+            /; (quest( \d| pro)?)/i                                             // Oculus Quest
             ], [MODEL, [VENDOR, FACEBOOK], [TYPE, WEARABLE]], [
 
             ///////////////////

diff --git a/test/device-test.json b/test/device-test.json
@@ -1628,6 +1628,15 @@
             "type": "wearable"
         }
     },
+    {
+        "desc": "Issue #747",
+        "ua": "python-requests/2.25.1",
+        "expect": {
+            "vendor": "undefined",
+            "model": "undefined",
+            "type": "undefined"
+        }
+    },
     {
         "desc": "OnePlus One",
         "ua": "Mozilla/5.0 (Linux; Android 4.4.4; A0001 Build/KTU84Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.59 Mobile Safari/537.36",
@@ -2012,7 +2021,7 @@
         "expect": {
             "vendor": "PICO",
             "model": "4",
-            "type": "xr"
+            "type": "wearable"
         }
     },
     {
@@ -2021,7 +2030,7 @@
         "expect": {
             "vendor": "PICO",
             "model": "4",
-            "type": "xr"
+            "type": "wearable"
         }
     },
     {
@@ -2030,7 +2039,7 @@
         "expect": {
             "vendor": "Pico",
             "model": "Neo3 Link",
-            "type": "xr"
+            "type": "wearable"
         }
     },
     {