Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #383: inverted non-auto-range axes defaulting to +-1 #418

Merged
merged 1 commit into from
May 25, 2021

Conversation

RalphSteinhagen
Copy link
Member

N.B. axis range clearing doesn't seem to be necessary when inverting the axis

  • added sample to illustrate the use of inverted axes (and also fix)
  • added another (unrelated) sample to illustrate plotting of limits
  • minor code clean-up (usage of 'var', unavoidable PMD/SONARLINT suppression).

N.B. axis range clearing doesn't seem to be necessary when inverting the axis
* added sample to illustrate use of inverted axes (and also fix)
* added another (unrelated) sample to illustrate plotting of limits
* minor code clean-up (usage of 'var', unavoidable PMD/SONARLINT suppression).
@RalphSteinhagen RalphSteinhagen temporarily deployed to coverage May 14, 2021 09:44 Inactive
@RalphSteinhagen RalphSteinhagen linked an issue May 14, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #418 (22c5d61) into master (8984113) will increase coverage by 0.15%.
The diff coverage is 67.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #418      +/-   ##
============================================
+ Coverage     53.22%   53.38%   +0.15%     
- Complexity     7338     7370      +32     
============================================
  Files           386      386              
  Lines         40646    40897     +251     
  Branches       6552     6657     +105     
============================================
+ Hits          21632    21831     +199     
- Misses        17462    17496      +34     
- Partials       1552     1570      +18     
Impacted Files Coverage Δ Complexity Δ
.../main/java/de/gsi/chart/axes/spi/AbstractAxis.java 77.30% <67.85%> (+0.88%) 216.00 <34.00> (+33.00)
.../java/de/gsi/dataset/locks/DefaultDataSetLock.java 58.06% <0.00%> (-2.16%) 16.00% <0.00%> (-2.00%)
...hart/plugins/measurements/DataSetMeasurements.java 75.77% <0.00%> (+0.17%) 153.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8984113...22c5d61. Read the comment docs.

@RalphSteinhagen RalphSteinhagen requested a review from ennerf May 17, 2021 10:08
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I could find no regressions in the samples.

@wirew0rm wirew0rm merged commit a3630e3 into master May 25, 2021
@wirew0rm wirew0rm deleted the fixIssue383 branch May 25, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed axis range does not work with inverted axis
2 participants