-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HistogramRenderer for non-equidistant and/or vertical histograms #292
Conversation
…LimitedIndexedTreeDataSet implementation
…nt x-axis sampling N.B. extra code-clean up replaced Math with MathBase were applicable
9e30cce
to
3143ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
============================================
+ Coverage 49.78% 50.33% +0.54%
- Complexity 6861 7031 +170
============================================
Files 380 382 +2
Lines 40065 40508 +443
Branches 6420 6523 +103
============================================
+ Hits 19947 20388 +441
+ Misses 18709 18679 -30
- Partials 1409 1441 +32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Histograms
orDataSet
sN.B. extra code-clean up replaced Math with MathBase were applicable
addresses some of the collateral issues posted in The first and last bins of histograms are not drawn - FIXED #80 Histogram bin width does not match actual bin range #246 BarChart: non equidistand data and last data point not drawn #265
Initial histogram concept/inspiration (courtesy Sitara S.):
example outputs: