Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HistogramRenderer for non-equidistant and/or vertical histograms #292

Merged
merged 7 commits into from
Nov 1, 2020

Conversation

RalphSteinhagen
Copy link
Member

Initial histogram concept/inspiration (courtesy Sitara S.):
image

example outputs:
image

image

image

wirew0rm
wirew0rm previously approved these changes Oct 30, 2020
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #292 into master will increase coverage by 0.54%.
The diff coverage is 67.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
+ Coverage     49.78%   50.33%   +0.54%     
- Complexity     6861     7031     +170     
============================================
  Files           380      382       +2     
  Lines         40065    40508     +443     
  Branches       6420     6523     +103     
============================================
+ Hits          19947    20388     +441     
+ Misses        18709    18679      -30     
- Partials       1409     1441      +32     
Impacted Files Coverage Δ Complexity Δ
.../de/gsi/dataset/spi/LimitedIndexedTreeDataSet.java 6.69% <3.22%> (-0.92%) 3.00 <0.00> (ø)
...ain/java/de/gsi/dataset/spi/AbstractHistogram.java 58.26% <66.66%> (+40.43%) 26.00 <12.00> (+20.00)
...a/de/gsi/chart/renderer/spi/HistogramRenderer.java 67.41% <67.41%> (ø) 84.00 <84.00> (?)
...et/src/main/java/de/gsi/dataset/spi/Histogram.java 83.82% <76.92%> (+71.47%) 31.00 <17.00> (+24.00)
...fx-math/src/main/java/de/gsi/math/DataSetMath.java 62.22% <78.15%> (+3.81%) 120.00 <35.00> (+26.00)
...hart/plugins/measurements/DataSetMeasurements.java 75.77% <100.00%> (ø) 153.00 <0.00> (ø)
...ataset/src/main/java/de/gsi/dataset/Histogram.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...gsi/dataset/testdata/spi/AbstractTestFunction.java 68.18% <100.00%> (ø) 10.00 <2.00> (ø)
...ava/de/gsi/dataset/testdata/spi/GaussFunction.java 100.00% <100.00%> (ø) 6.00 <1.00> (+1.00)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ea2d1...d3b08a6. Read the comment docs.

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wirew0rm wirew0rm closed this Oct 31, 2020
@RalphSteinhagen RalphSteinhagen merged commit dd0c2ca into master Nov 1, 2020
@RalphSteinhagen RalphSteinhagen deleted the histogramRenderer branch November 1, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants