Add table view only to chart if really shown #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirew0rm
previously approved these changes
Oct 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
============================================
+ Coverage 49.52% 49.80% +0.28%
- Complexity 6848 6864 +16
============================================
Files 380 380
Lines 40057 40065 +8
Branches 6419 6420 +1
============================================
+ Hits 19837 19955 +118
+ Misses 18824 18706 -118
- Partials 1396 1404 +8
Continue to review full report at Codecov.
|
dedeibel
force-pushed
the
table-viewer-add-table-only-when-visible
branch
from
39ad71d to
9e40cd5
Compare
- Mitigates problem of it taking control over the charts size
dedeibel
force-pushed
the
table-viewer-add-table-only-when-visible
branch
from
9e40cd5 to
ac59c05
Compare
|
Complexity increasing per file
==============================
- chartfx-chart/src/test/java/de/gsi/chart/plugins/TableViewerTest.java 1
See the complete overview on Codacy |
wirew0rm
approved these changes
Oct 23, 2020
wirew0rm
pushed a commit
that referenced
this pull request
Jan 26, 2021
TableViewer: table cells can now be selected again - Mouse transparency was set incorrectly after commit eb7a286 (#280) Authored-by: Benjamin Peter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I talked about it with akrimm, please ask if you want more info.