fixed setAutoRangePadding() regression bug #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
============================================
- Coverage 49.43% 49.42% -0.01%
+ Complexity 6850 6837 -13
============================================
Files 380 380
Lines 40108 40056 -52
Branches 6426 6418 -8
============================================
- Hits 19826 19799 -27
+ Misses 18891 18858 -33
- Partials 1391 1399 +8
Continue to review full report at Codecov.
|
RalphSteinhagen
force-pushed
the
fixAutoRangePadding
branch
2 times, most recently
from
3a68a7d to
feb6cdf
Compare
…oscopeAxis and DefaultNumericAxis N.B. fixes problem in OscilloscopeAxisSample regarding switching from an auto-ranging to user-defined axis two-fold: a) an ill-defined tickUnit could previously yield an nearly unlimited amount of tick marks (i.e. tickUnit == 200 for > 2e11 range) -> fixed in calculateMajorTickValues(...) and calculateMinorTickValues(...) b) switching between auto-ranging and user-based ranging could leave the scale/tick unit dangling for one update if forceRedraw() function was called ... fixed in recomputeTickMarks() by explicitly updating the tick unit in both layoutChildren and forceRedraw() function...
|
Complexity decreasing per file
==============================
+ chartfx-chart/src/main/java/de/gsi/chart/XYChart.java -2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed setAutoRangePadding() regression bug and simplified auto range handling
recomputation and redrawing of axes (on range-, tick unit, and notably scale changes) and update of the internal caches was done sometimes out-of-order causing the canvas being redrawn before the new axis settings have been in place. Previously this appeared to be less frequently visible since the change of the min/max axis range property triggered subsequent update events and thus drawing of the canvas.
N.B. Interestingly, this did not show up in the numeric unit-tests and only while visually testing. The numerical API results seemed to have been always correct and only the canvas update has been missing sometimes.
Re-ordered recomputation of auto ranges, moved most of the computation into the
AbstractAxis::invalidateRange(..)removed redundant code in theAbstractAxisand derived classes (notably 'getAxisRange()which has been performing the same function as the existing 'getRange()). The performance -- especially for rare or one-time updates -- should be more consistent now.Updated the SimpleChartSample to reflect and test these changes (here with 50% padding on top and bottom of the DataSet):
and updated API in the commented code section (became dated/incorrect). Collateral effects remain to be checked/tested.