-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Majordomo Broker V0.1 PoC #273
Conversation
98dde30
to
721b1ad
Compare
721b1ad
to
180ac47
Compare
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
============================================
- Coverage 47.90% 43.68% -4.22%
- Complexity 5624 5869 +245
============================================
Files 341 367 +26
Lines 34827 39562 +4735
Branches 5699 6346 +647
============================================
+ Hits 16683 17282 +599
- Misses 17101 21231 +4130
- Partials 1043 1049 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
180ac47
to
039c8df
Compare
039c8df
to
e7675f7
Compare
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoClientV2.java 3
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/SimpleEchoServiceWorker.java 1
- microservice/src/test/java/de/gsi/microservice/rbac/BasicRbacRole.java 1
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoWorker.java 7
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoClientV1.java 9
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoProtocol.java 22
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/legacy/CmwLightClient.java 6
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/ClientSampleV2.java 7
- microservice/src/test/java/de/gsi/microservice/concepts/RestBehindRouterEvaluation.java 11
- microservice/src/test/java/de/gsi/microservice/utils/SystemProperties.java 4
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/ClientSampleV1.java 6
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoBroker.java 19
- microservice/src/test/java/de/gsi/microservice/utils/WorkerThreadFactory.java 6
- microservice/src/test/java/de/gsi/microservice/rbac/RbacToken.java 5
- microservice/src/test/java/de/gsi/microservice/concepts/BlockingQueueTests.java 5
- microservice/src/test/java/de/gsi/microservice/concepts/PushPullTests.java 5
- microservice/src/test/java/de/gsi/microservice/concepts/RoundTripAndNotifyEvaluation.java 6
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoBrokerTests.java 1
Clones added
============
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/legacy/CmwLightClient.java 2
- microservice/src/test/java/de/gsi/microservice/concepts/BlockingQueueTests.java 2
- microservice/src/test/java/de/gsi/microservice/concepts/PushPullTests.java 2
See the complete overview on Codacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good
Majordomo Broker V0.1 proof-of-concept to be developed into an independent microservice middle-ware
This is the reference implementation to compare future iterations and upgrades against.