Skip to content

Commit

Permalink
removed unnecessary getDataSetsCopy method
Browse files Browse the repository at this point in the history
  • Loading branch information
ennerf committed Sep 15, 2023
1 parent c453325 commit 483679f
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ default boolean drawLegendSymbol(DataSetNode style, Canvas canvas) {

ObservableList<DataSet> getDatasets();

ObservableList<DataSet> getDatasetsCopy(); // TODO: get rid of this? add getDatasetNodes?

ObservableList<DataSetNode> getDatasetNodes();

default DataSetNode getStyleableNode(DataSet dataSet) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,25 +112,6 @@ protected ObservableList<DataSetNode> getInternalDataSetNodes() {
return dataSetNodes;
}

@Override
public ObservableList<DataSet> getDatasetsCopy() {
return getDatasetsCopy(getDatasets());
}

protected ObservableList<DataSet> getDatasetsCopy(final ObservableList<DataSet> localDataSets) {
final long start = ProcessingProfiler.getTimeStamp();
final ObservableList<DataSet> dataSets = FXCollections.observableArrayList();
for (final DataSet dataSet : localDataSets) {
if (dataSet instanceof DataSetError) {
dataSets.add(new DoubleErrorDataSet(dataSet));
} else {
dataSets.add(new DoubleDataSet(dataSet));
}
}
ProcessingProfiler.getTimeDiff(start);
return dataSets;
}

public Axis getFirstAxis(final Orientation orientation) {
for (final Axis axis : getAxes()) {
if (axis.getSide() == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,6 @@ public ObservableList<DataSet> getDatasets() {
return FXCollections.emptyObservableList();
}

@Override
public ObservableList<DataSet> getDatasetsCopy() {
return FXCollections.emptyObservableList();
}

@Override
public ObservableList<DataSetNode> getDatasetNodes() {
return FXCollections.emptyObservableList();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,6 @@ public ObservableList<DataSet> getDatasets() {
return FXCollections.observableArrayList();
}

@Override
public ObservableList<DataSet> getDatasetsCopy() {
return FXCollections.observableArrayList();
}

@Override
public ObservableList<DataSetNode> getDatasetNodes() {
return FXCollections.emptyObservableList();
Expand Down

0 comments on commit 483679f

Please sign in to comment.