Fix empty title handling in admonitions and details (#2235)

docs/src/markdown/about/changelog.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 10.4.1
+
+-   **FIX**: Block Admonitions: Empty titles should be respected.
+-   **FIX**: Block Details: Empty summary should be respected.
+
 ## 10.4
 
 -   **NEW**: Snippets: Allow PathLike objects for `base_path` to better support interactions with MkDocs.

pymdownx/__meta__.py

@@ -185,5 +185,5 @@ def parse_version(ver, pre=False):
     return Version(major, minor, micro, release, pre, post, dev)
 
 
-__version_info__ = Version(10, 4, 0, "final")
+__version_info__ = Version(10, 4, 1, "final")
 __version__ = __version_info__._get_canonical()

pymdownx/blocks/admonition.py

@@ -49,12 +49,11 @@ def on_create(self, parent):
         el = etree.SubElement(parent, 'div', {'class': ' '.join(classes)})
 
         # Create the title
-        if not self.argument:
-            if not atype:
-                title = None
-            else:
+        title = None
+        if self.argument is None:
+            if atype:
                 title = atype.capitalize()
-        else:
+        elif self.argument:
             title = self.argument
 
         if title is not None:

pymdownx/blocks/details.py

@@ -60,12 +60,11 @@ def on_create(self, parent):
         el = etree.SubElement(parent, 'details', attributes)
 
         # Create the summary
-        if not self.argument:
-            if not dtype:
-                summary = None
-            else:
+        summary = None
+        if self.argument is None:
+            if dtype:
                 summary = dtype.capitalize()
-        else:
+        elif self.argument:
             summary = self.argument
 
         # Create the summary

tests/test_extensions/test_blocks/test_admonitions.py

@@ -48,6 +48,26 @@ def test_type_no_title(self):
             True
         )
 
+    def test_type_empty_title(self):
+        """Test test empty title."""
+
+        self.check_markdown(
+            R'''
+            /// admonition |
+                type: note
+                attrs: {class: other}
+
+            Some *content*
+            ///
+            ''',
+            r'''
+            <div class="admonition note other">
+            <p>Some <em>content</em></p>
+            </div>
+            ''',
+            True
+        )
+
     def test_admonition(self):
         """Test admonition with title."""
 

tests/test_extensions/test_blocks/test_details.py

@@ -48,6 +48,26 @@ def test_type_no_title(self):
             True
         )
 
+    def test_type_empty_title(self):
+        """Test test empty title."""
+
+        self.check_markdown(
+            R'''
+            /// details |
+                type: note
+                attrs: {class: other}
+
+            Some *content*
+            ///
+            ''',
+            r'''
+            <details class="note other">
+            <p>Some <em>content</em></p>
+            </details>
+            ''',
+            True
+        )
+
     def test_details(self):
         """Test details with title."""